Skip to content

Align debugger Chrome launch flags with Meta-internal version #44180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
motiz88 wants to merge 1 commit into from
Closed

Align debugger Chrome launch flags with Meta-internal version #44180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/dev-middleware/src/utils/DefaultBrowserLauncher.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,23 @@ const DefaultBrowserLauncher: BrowserLauncher = {
`react-native-debugger-frontend-${browserType}`,
);
const launchedChrome = await ChromeLauncher.launch({
chromePath,
chromeFlags: [
...ChromeLauncher.Launcher.defaultFlags().filter(
/**
* This flag controls whether Chrome treats a visually covered (occluded) tab
* as "backgrounded". We launch CDT as a single tab/window via `--app`, so we
* do want Chrome to treat our tab as "backgrounded" when the UI is covered.
* Omitting this flag allows "visibilitychange" events to fire properly.
*/
flag => flag !== '--disable-backgrounding-occluded-windows',
),
`--app=${url}`,
`--user-data-dir=${userDataDir}`,
'--window-size=1200,600',
'--guest',
],
chromePath,
ignoreDefaultFlags: true,
});

return {
Expand Down