Small refactor in RuntimeScheduler_Modern to favor references over shared_ptr for non-owning function args #43852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646389 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 4, 2024
…ared_ptr for non-owning function args (facebook#43852) Summary: Pull Request resolved: facebook#43852 Changelog: [internal] Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`. Reviewed By: javache Differential Revision: D55646389
rubennorte
force-pushed
the
export-D55646389
branch
from
800c3db to
735071a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646389 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646389 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 4, 2024
…ared_ptr for non-owning function args (facebook#43852) Summary: Pull Request resolved: facebook#43852 Changelog: [internal] Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`. Reviewed By: javache Differential Revision: D55646389
rubennorte
force-pushed
the
export-D55646389
branch
from
735071a to
8cebfe6
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 5, 2024
…ared_ptr for non-owning function args (facebook#43852) Summary: Pull Request resolved: facebook#43852 Changelog: [internal] Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`. Reviewed By: javache Differential Revision: D55646389
rubennorte
force-pushed
the
export-D55646389
branch
from
8cebfe6 to
dc42b41
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646389 |
Base commit: 2fcdab4 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646389 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 5, 2024
…ared_ptr for non-owning function args (facebook#43852) Summary: Pull Request resolved: facebook#43852 Changelog: [internal] Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`. Reviewed By: javache Differential Revision: D55646389
rubennorte
force-pushed
the
export-D55646389
branch
from
dc42b41 to
49fedaa
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646389 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 5, 2024
…ared_ptr for non-owning function args (facebook#43852) Summary: Pull Request resolved: facebook#43852 Changelog: [internal] Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`. Reviewed By: javache Differential Revision: D55646389
rubennorte
force-pushed
the
export-D55646389
branch
from
49fedaa to
56322d9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646389 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 8, 2024
…ared_ptr for non-owning function args (facebook#43852) Summary: Pull Request resolved: facebook#43852 Changelog: [internal] Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`. Reviewed By: javache Differential Revision: D55646389
rubennorte
force-pushed
the
export-D55646389
branch
from
56322d9 to
c70d6b2
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 9, 2024
…ared_ptr for non-owning function args (facebook#43852) Summary: Pull Request resolved: facebook#43852 Changelog: [internal] Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`. Reviewed By: javache Differential Revision: D55646389
rubennorte
force-pushed
the
export-D55646389
branch
from
c70d6b2 to
65d888e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646389 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646389 |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 9, 2024
…ared_ptr for non-owning function args (facebook#43852) Summary: Pull Request resolved: facebook#43852 Changelog: [internal] Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`. Reviewed By: javache Differential Revision: D55646389
rubennorte
force-pushed
the
export-D55646389
branch
from
65d888e to
aeb1950
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Apr 9, 2024
…ared_ptr for non-owning function args (facebook#43852) Summary: Pull Request resolved: facebook#43852 Changelog: [internal] Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`. Reviewed By: javache Differential Revision: D55646389
rubennorte
force-pushed
the
export-D55646389
branch
from
aeb1950 to
1e85043
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646389 |
Differential Revision: D55646390
Differential Revision: D55646393
Differential Revision: D55646394
Differential Revision: D55646391
Differential Revision: D55646392
…ared_ptr for non-owning function args (facebook#43852) Summary: Pull Request resolved: facebook#43852 Changelog: [internal] Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`. Reviewed By: javache Differential Revision: D55646389
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D55646389 |
rubennorte
force-pushed
the
export-D55646389
branch
from
1e85043 to
458e874
Compare
Contributor
|
This pull request has been merged in d35de2d. |
Titozzz
pushed a commit
that referenced
this pull request
Jun 18, 2024
…ared_ptr for non-owning function args (#43852) Summary: Pull Request resolved: #43852 Changelog: [internal] Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`. Reviewed By: javache Differential Revision: D55646389 fbshipit-source-id: d01dcba7b1551d349d21717ba585828ed7fb3259
Titozzz
pushed a commit
that referenced
this pull request
Jun 18, 2024
…ared_ptr for non-owning function args (#43852) Summary: Pull Request resolved: #43852 Changelog: [internal] Just a small refactor so we rely less on shared pointers within `RuntimeSCheduler_Modern`. Reviewed By: javache Differential Revision: D55646389 fbshipit-source-id: d01dcba7b1551d349d21717ba585828ed7fb3259
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [internal]
Just a small refactor so we rely less on shared pointers within
RuntimeSCheduler_Modern.Differential Revision: D55646389