[iOS] Fix RCTRCTComposedViewRegistry for Old Arch by adding count and keyEnumerator #43850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
Author
|
@WoLewicki can you try to apply this patch? I tried and everything seems to work fine. In the video you can see the examples running and that we are using the old architecture. Screen.Recording.2024-04-04.at.13.39.21.mov |
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
WoLewicki
reviewed
Apr 4, 2024
Contributor
WoLewicki
left a comment
WoLewicki
left a comment
There was a problem hiding this comment.
It works correctly in my setup too 🎉 Only thing I am worried about is using any other NSDictionary methods in the future and encountering the same problem then.
Contributor
|
@cipolleschi merged this pull request in 82b58d0. |
|
This pull request was successfully merged by @cipolleschi in 82b58d0. When will my fix make it into a release? | How to file a pick request? |
cortinico
pushed a commit
that referenced
this pull request
Apr 8, 2024
…umerator (#43850) Summary: In the Old Architecture and for Swift Libraries, these two methods are used to initialize a new disctionary but their implementation was missing so some libraries like lottie were failig to build. ## Changelog: [Internal] - Implement missing `count` and `keyEnumerator` methods for RCTComposedViewRegistry Pull Request resolved: #43850 Test Plan: Tested locally with the repro provided by SWM Reviewed By: javache Differential Revision: D55743648 Pulled By: cipolleschi fbshipit-source-id: 7bdb92625341cd704b8b09920ab3223a2ca61a54
This was referenced Apr 9, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In the Old Architecture and for Swift Libraries, these two methods are used to initialize a new disctionary but their implementation was missing so some libraries like lottie were failig to build.
Changelog:
[Internal] - Implement missing
countandkeyEnumeratormethods for RCTComposedViewRegistryTest Plan:
Tested locally with the repro provided by SWM