Skip to content

Conversation

@huntie
Copy link
Member

@huntie huntie commented Mar 18, 2024

Summary:
Switch to the new unified release workflow by default, now that this has been validated on the 0.74-stable branch.

  • Remove --use-new-workflow flag and remove legacy logic.
  • Remove legacy prepare_package_for_release CI job, and use run_new_release_workflow -> run_release_workflow as new workflow condition match.

Changelog: [Internal]

Differential Revision: D55027120

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 18, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55027120

huntie added a commit to huntie/react-native that referenced this pull request Mar 18, 2024
Summary:

Switch to the new unified release workflow by default, now that this has been validated on the `0.74-stable` branch.

- Remove `--use-new-workflow` flag and remove legacy logic.
- Remove legacy `prepare_package_for_release` CI job, and use `run_new_release_workflow` -> `run_release_workflow` as new workflow condition match.

Changelog: [Internal]

Differential Revision: D55027120
huntie added a commit to huntie/react-native that referenced this pull request Mar 19, 2024
Summary:

Switch to the new unified release workflow by default, now that this has been validated on the `0.74-stable` branch.

- Remove `--use-new-workflow` flag and remove legacy logic.
- Remove legacy `prepare_package_for_release` CI job, and use `run_new_release_workflow` -> `run_release_workflow` as new workflow condition match.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D55027120
huntie added a commit to huntie/react-native that referenced this pull request Mar 19, 2024
Summary:

Switch to the new unified release workflow by default, now that this has been validated on the `0.74-stable` branch.

- Remove `--use-new-workflow` flag and remove legacy logic.
- Remove legacy `prepare_package_for_release` CI job, and use `run_new_release_workflow` -> `run_release_workflow` as new workflow condition match.

Changelog: [Internal]

Differential Revision: D55027120
@huntie huntie force-pushed the export-D55027120 branch from 113c5be to b4e063e Compare March 19, 2024 12:10
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55027120

@analysis-bot
Copy link

analysis-bot commented Mar 19, 2024

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 18,125,893 +1
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,491,246 +3
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 4a58f06
Branch: main

Summary:

Switch to the new unified release workflow by default, now that this has been validated on the `0.74-stable` branch.

- Remove `--use-new-workflow` flag and remove legacy logic.
- Remove legacy `prepare_package_for_release` CI job, and use `run_new_release_workflow` -> `run_release_workflow` as new workflow condition match.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D55027120
@huntie huntie force-pushed the export-D55027120 branch from b4e063e to d890f84 Compare March 19, 2024 13:29
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D55027120

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 19, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in bb4d13e.

huntie added a commit that referenced this pull request Mar 20, 2024
Summary:
Pull Request resolved: #43533

Switch to the new unified release workflow by default, now that this has been validated on the `0.74-stable` branch.

- Remove `--use-new-workflow` flag and remove legacy logic.
- Remove legacy `prepare_package_for_release` CI job, and use `run_new_release_workflow` -> `run_release_workflow` as new workflow condition match.

Changelog: [Internal]

Reviewed By: cortinico

Differential Revision: D55027120

fbshipit-source-id: 7c05cdff95ac369ce6cd1201ccfc5718798c4da6

# Conflicts:
#	scripts/releases-ci/prepare-package-for-release.js
This was referenced Jun 28, 2024
@huntie huntie deleted the export-D55027120 branch September 9, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants