Bring back the UNSET constant to TextAttributeProps #43491
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff brings back the `UNSET` constant to `TextAttributeProps`. The removal of this constant was an unnecessary breaking change, that has broken several third-party libraries. Changelog: [Android][Fixed] - Bring back the UNSET constant to TextAttributeProps. Differential Revision: D54899524
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54899524 |
Contributor
|
This pull request has been merged in 9700540. |
huntie
pushed a commit
that referenced
this pull request
Mar 18, 2024
Summary: Pull Request resolved: #43491 This diff brings back the `UNSET` constant to `TextAttributeProps`. The removal of this constant was an unnecessary breaking change, that has broken several third-party libraries. Changelog: [Android][Fixed] - Bring back the UNSET constant to TextAttributeProps. Reviewed By: fabriziocucci Differential Revision: D54899524 fbshipit-source-id: 368bde77d43f310fd458537d0191d09174fa5167
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff brings back the
UNSETconstant toTextAttributeProps.The removal of this constant was an unnecessary breaking change, that has broken several third-party libraries.
Changelog: [Android][Fixed] - Bring back the UNSET constant to TextAttributeProps.
Differential Revision: D54899524