Properly handle RR and CMD+M in Bridgeless Mode #43460
Closed
+21
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Currently pressing the menu button (or CMD+M) is broken on Bridgeless mode. Also pressing RR is not reloading the App. That's because some Bridgeless API haven't been reimplemented correctly on Android. I'm fixing them here. Fixes facebook#43451 Changelog: [Android] [Fixed] - Properly handle RR and CMD+M in Bridgeless Mode Differential Revision: D54852959
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54852959 |
facebook-github-bot
added
CLA Signed
Base commit: 38cbc08 |
Contributor
|
This pull request has been merged in e9f66d9. |
huntie
pushed a commit
that referenced
this pull request
Mar 18, 2024
Summary: Pull Request resolved: #43460 Currently pressing the menu button (or CMD+M) is broken on Bridgeless mode. Also pressing RR is not reloading the App. That's because some Bridgeless API haven't been reimplemented correctly on Android. I'm fixing them here. Fixes #43451 Changelog: [Android] [Fixed] - Properly handle RR and CMD+M in Bridgeless Mode Reviewed By: huntie Differential Revision: D54852959 fbshipit-source-id: 8fbbdab6818da9177e6db40e45d35258c7f5e236
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Currently pressing the menu button (or CMD+M) is broken on Bridgeless mode.
Also pressing RR is not reloading the App.
That's because some Bridgeless API haven't been reimplemented correctly on Android. I'm fixing them here.
Fixes #43451
Changelog:
[Android] [Fixed] - Properly handle RR and CMD+M in Bridgeless Mode
Differential Revision: D54852959