[Fabric] iOS: Fixes textinput onscroll event payload #43445
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
@sammy-SC has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
/rebase |
zhongwuzw
force-pushed
the
features/fix_scroll_event
branch
from
44961bc to
91dd672
Compare
sammy-SC
reviewed
Mar 14, 2024
| payload.setProperty(runtime, "layoutMeasurement", layoutMeasurement); | ||
| } | ||
|
|
||
| payload.setProperty(runtime, "zoomScale", textInputMetrics.zoomScale ?: 1); |
Contributor
There was a problem hiding this comment.
why is this check needed? Isn't zoomScale always set from Objective-C?
If is isn't, wouldn't it be better to assign a default value to zoomScale?
Contributor
Author
There was a problem hiding this comment.
I just kept the same as Old arch
zoomScale should be 1.0, and we think 0 is a invalid value.
Contributor
There was a problem hiding this comment.
that's fair. Thanks for the clarification.
sammy-SC
approved these changes
Mar 14, 2024
Contributor
sammy-SC
left a comment
sammy-SC
left a comment
There was a problem hiding this comment.
thank you! I just one small question but that isn't blocking.
Contributor
cipolleschi
pushed a commit
that referenced
this pull request
Jun 3, 2024
Summary: Fixes #43428 . cc cortinico . ## Changelog: [IOS] [FIXED] - [Fabric] iOS: Fixes textinput onscroll event payload Pull Request resolved: #43445 Test Plan: ``` const onInputScroll = (e) => { if (Platform.OS !== "web") { const { nativeEvent: { contentOffset: { x, y }, }, } = e; console.log('onInputScroll ====', e?.nativeEvent) } }; <TextInput onScroll={onInputScroll} // ref={inputRef} multiline /> ``` Reviewed By: cortinico Differential Revision: D54813378 Pulled By: sammy-SC fbshipit-source-id: 76671fbb390c2fbc67a9c29b6c2a834ba699fff4
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #43428 . cc @cortinico .
Changelog:
[IOS] [FIXED] - [Fabric] iOS: Fixes textinput onscroll event payload
Test Plan: