Skip to content

Conversation

@Kudo
Copy link
Contributor

@Kudo Kudo commented Mar 9, 2024

Summary:

add overridable hooks for RCTHost and RCTSurfaceHostingProxyRootView. this are required for expo's pluggable system to serve expo-dev-client and expo-updates integration.

this pr introduces new createSurfaceViewWithReactHost:moduleName:initProps: and changes createReactHost for returning an instance rather than mutating member variables.

this pr is based on 0.74-stable only since on main there's ec928d7 which is good enough for the use case.

Changelog:

[IOS] [ADDED] - Add overridable hooks for bridgeless creation in RCTAppDelegate

Test Plan:

ci passed

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner labels Mar 9, 2024
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,816,397 -237,088
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,174,775 -233,154
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: e2157f0
Branch: main

@huntie
Copy link
Member

huntie commented Mar 11, 2024

Thanks @Kudo. We were able to merge all of #43325 instead :).

@huntie huntie closed this Mar 11, 2024
@Kudo Kudo deleted the @kudo/bridgeless-rctdelegate-hook branch March 11, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Contributor A React Native contributor. p: Expo Partner: Expo Partner Pick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants