Enable event loop by default when bridgeless is enabled #43396

rubennorte · 2024-03-08T18:57:29Z

Changelog: [General][Changed] Enabled new event loop behavior when bridgeless (new architecture) is enabled.

Fixes #42742 and probably #33006.

Differential Revision: D54682678

facebook-github-bot · 2024-03-08T18:58:04Z

This pull request was exported from Phabricator. Differential Revision: D54682678

facebook-github-bot · 2024-03-11T11:09:17Z

This pull request was exported from Phabricator. Differential Revision: D54682678

Summary: Pull Request resolved: facebook#43396 Changelog: [General][Changed] Enabled new event loop behavior when bridgeless (new architecture) is enabled. Differential Revision: D54682678

analysis-bot · 2024-03-11T11:41:36Z

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	18,125,846	-1,248
android	hermes	armeabi-v7a	n/a	--
android	hermes	x86	n/a	--
android	hermes	x86_64	n/a	--
android	jsc	arm64-v8a	21,495,385	+1,560
android	jsc	armeabi-v7a	n/a	--
android	jsc	x86	n/a	--
android	jsc	x86_64	n/a	--

Base commit: e180f80
Branch: main

facebook-github-bot · 2024-03-12T10:41:31Z

This pull request was exported from Phabricator. Differential Revision: D54682678

Summary: Pull Request resolved: facebook#43396 Changelog: [General][Changed] Enabled new event loop behavior when bridgeless (new architecture) is enabled. Differential Revision: D54682678

facebook-github-bot · 2024-03-12T10:48:02Z

This pull request was exported from Phabricator. Differential Revision: D54682678

Summary: Pull Request resolved: facebook#43396 Changelog: [General][Changed] Enabled new event loop behavior when bridgeless (new architecture) is enabled. Differential Revision: D54682678

facebook-github-bot · 2024-03-12T13:45:55Z

This pull request was exported from Phabricator. Differential Revision: D54682678

Summary: Pull Request resolved: facebook#43396 Changelog: [General][Changed] Enabled new event loop behavior when bridgeless (new architecture) is enabled. Reviewed By: rshest Differential Revision: D54682678

Summary: Changelog: [General][Changed] Enabled new event loop behavior when bridgeless (new architecture) is enabled. Reviewed By: rshest Differential Revision: D54682678

facebook-github-bot · 2024-03-13T13:04:19Z

This pull request was exported from Phabricator. Differential Revision: D54682678

Summary: Changelog: [General][Changed] Enabled new event loop behavior when bridgeless (new architecture) is enabled. Reviewed By: rshest Differential Revision: D54682678

facebook-github-bot · 2024-03-13T13:40:26Z

This pull request was exported from Phabricator. Differential Revision: D54682678

Summary: Changelog: [General][Changed] Enabled new event loop behavior when bridgeless (new architecture) is enabled. Reviewed By: rshest Differential Revision: D54682678

facebook-github-bot · 2024-03-15T10:12:57Z

This pull request was exported from Phabricator. Differential Revision: D54682678

Summary: Changelog: [General][Changed] Enabled new event loop behavior when bridgeless (new architecture) is enabled. Reviewed By: rshest Differential Revision: D54682678

facebook-github-bot · 2024-03-15T12:31:28Z

This pull request was exported from Phabricator. Differential Revision: D54682678

facebook-github-bot · 2024-03-15T12:35:42Z

This pull request was exported from Phabricator. Differential Revision: D54682678

Summary: Changelog: [General][Changed] Enabled new event loop behavior when bridgeless (new architecture) is enabled. Reviewed By: rshest Differential Revision: D54682678

facebook-github-bot · 2024-03-15T14:54:46Z

This pull request was exported from Phabricator. Differential Revision: D54682678

Summary: Changelog: [General][Changed] - sync React renderers to 18.3.0-canary-9372c6311-20240315 Syncs React renderers to facebook/react@9372c63 which is canary for 18.3.0-canary-9372c6311-20240315. This includes the necessary changes to enable the use of microtasks for scheduling in Fabric. Differential Revision: D54947212

Summary: Changelog: [General][Changed] Enabled new event loop behavior when bridgeless (new architecture) is enabled. Reviewed By: rshest Differential Revision: D54682678

facebook-github-bot · 2024-03-15T18:11:15Z

This pull request was exported from Phabricator. Differential Revision: D54682678

facebook-github-bot · 2024-03-15T18:11:32Z

This pull request was exported from Phabricator. Differential Revision: D54682678

facebook-github-bot · 2024-03-18T11:57:38Z

This pull request has been merged in 87b73a0.

Summary: Pull Request resolved: #43396 Changelog: [General][Changed] Enabled new event loop behavior when bridgeless (new architecture) is enabled. Reviewed By: rshest Differential Revision: D54682678 fbshipit-source-id: ff8c45bc1caae0e9182aa94d915d7b6f9427caf9

kraenhansen · 2024-06-19T12:30:31Z

I tried disabling our workaround for #33006 based on the value of the ReactNativeFeatureFlags.enableMicrotasks() and unfortunately it doesn't seem to solve it.

I wonder if it'd be possible to extend rn-tester's NativeCxxModuleExample to exhibit this behaviour 🤔

rubennorte · 2024-06-19T12:50:23Z

I tried disabling our workaround for #33006 based on the value of the ReactNativeFeatureFlags.enableMicrotasks() and unfortunately it doesn't seem to solve it.

I wonder if it'd be possible to extend rn-tester's NativeCxxModuleExample to exhibit this behaviour 🤔

Could you please open a new issue with the details about how to reproduce this with the new architecture enabled? (that enables the new event loop by default).

I took a quick look at the example in https://github.com/mfbx9da4/react-native-jsi-promise/blob/main/ios/JsiPromise.mm and I still see problems about how those promises are resolved (you can't call into JSI from any threads/queues, you should use the JS thread or you'd get undefined behaviors). To call into JS, you should use things like the call invoker that's passed to C++ TurboModules, which allows you to schedule async jobs in the JS thread, where you can safely resolve the promise.

kraenhansen · 2024-06-19T13:00:32Z

Could you please open a new issue with the details about how to reproduce this with the new architecture enabled?

I agree, that's probably the best next step, which was why I mentioned extending rn-tester. I mainly wanted to mention that I failed to verify the fix in our code and I'll have to circle back to crafting a minimal reproduction of this later. I'll create a new issue referencing this PR and the original issue and tagging you, once I eventually get there 👍

you should use the JS thread or you'd get undefined behaviors

We're asserting the thread is the JS thread in our implementation (I'm not associated with the example you posted).

kraenhansen · 2024-07-17T11:22:59Z

Please disregard my comments above .. As I outline in my latest comment on #33006 our way of scheduling async work was not through the CallInvoker and therefore didn't trigger drainage of the microtask queue.

facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 8, 2024

facebook-github-bot added the fb-exported label Mar 8, 2024

rubennorte force-pushed the export-D54682678 branch from 8d4c8a3 to c863eed Compare March 11, 2024 11:09

rubennorte force-pushed the export-D54682678 branch from c863eed to 9082cb8 Compare March 12, 2024 10:41

rubennorte force-pushed the export-D54682678 branch from 9082cb8 to 0ef76b5 Compare March 12, 2024 10:48

rubennorte force-pushed the export-D54682678 branch from 0ef76b5 to 5ff82d4 Compare March 12, 2024 13:46

rubennorte force-pushed the export-D54682678 branch from 5ff82d4 to e14b957 Compare March 13, 2024 13:04

rubennorte force-pushed the export-D54682678 branch from e14b957 to 8ea1563 Compare March 13, 2024 13:40

rubennorte force-pushed the export-D54682678 branch from 8ea1563 to 2e7ae6f Compare March 15, 2024 10:12

rubennorte force-pushed the export-D54682678 branch from 2e7ae6f to f9cd095 Compare March 15, 2024 12:31

rubennorte force-pushed the export-D54682678 branch from b3f8274 to 3f50f19 Compare March 15, 2024 14:54

rubennorte added 2 commits March 15, 2024 11:10

Enable event loop by default when bridgeless is enabled (facebook#43396)

1ed4b83

Summary: Changelog: [General][Changed] Enabled new event loop behavior when bridgeless (new architecture) is enabled. Reviewed By: rshest Differential Revision: D54682678

rubennorte force-pushed the export-D54682678 branch 2 times, most recently from eaa0964 to 1ed4b83 Compare March 15, 2024 18:11

facebook-github-bot closed this in 87b73a0 Mar 18, 2024

facebook-github-bot added the Merged This PR has been merged. label Mar 18, 2024

rubennorte mentioned this pull request Mar 18, 2024

Hermes WeakRef Support in React Native #42742

Closed

rubennorte deleted the export-D54682678 branch March 18, 2024 12:07

atn4z7 mentioned this pull request May 8, 2024

CP-8525: Improve Android performance (polyfill promise with es6-promise) ava-labs/core-mobile#1293

Merged

4 tasks

kraenhansen mentioned this pull request Jun 18, 2024

RJS-2815: React Native bridgeless support (take 2) realm/realm-js#6737

Merged

7 tasks

kraenhansen mentioned this pull request Jun 28, 2024

Revisit our workaround for flushing the microtask queue after calls from C++ into JS realm/realm-js#6768

Closed

This was referenced Jun 28, 2024

[CI] Move iOS Executors to M1 #45213

Closed

[Hermes] Bump Hermes #45220

Merged

cipolleschi mentioned this pull request Jul 22, 2024

[RN][0.74]Fix XROS build #45580

Merged

cipolleschi mentioned this pull request Jul 31, 2024

[RN][Hermes] Fore Hermes versions for slices through env var #45840

Merged

cipolleschi mentioned this pull request Jan 23, 2025

[RN][0.74] Fix ruby for CI #48885

Merged

Enable event loop by default when bridgeless is enabled #43396

Enable event loop by default when bridgeless is enabled #43396

Uh oh!

Conversation

rubennorte commented Mar 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Mar 8, 2024

Uh oh!

facebook-github-bot commented Mar 11, 2024

Uh oh!

analysis-bot commented Mar 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Mar 12, 2024

Uh oh!

facebook-github-bot commented Mar 12, 2024

Uh oh!

facebook-github-bot commented Mar 12, 2024

Uh oh!

facebook-github-bot commented Mar 13, 2024

Uh oh!

facebook-github-bot commented Mar 13, 2024

Uh oh!

facebook-github-bot commented Mar 15, 2024

Uh oh!

facebook-github-bot commented Mar 15, 2024

Uh oh!

facebook-github-bot commented Mar 15, 2024

Uh oh!

facebook-github-bot commented Mar 15, 2024

Uh oh!

facebook-github-bot commented Mar 15, 2024

Uh oh!

facebook-github-bot commented Mar 15, 2024

Uh oh!

facebook-github-bot commented Mar 18, 2024

Uh oh!

kraenhansen commented Jun 19, 2024

Uh oh!

rubennorte commented Jun 19, 2024

Uh oh!

kraenhansen commented Jun 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kraenhansen commented Jul 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

rubennorte commented Mar 8, 2024 •

edited

Loading

analysis-bot commented Mar 11, 2024 •

edited

Loading

kraenhansen commented Jun 19, 2024 •

edited

Loading