fix(iOS) [0.74]: properly warn about createRootViewWithBridge #43146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
Author
|
cc: @cipolleschi |
Base commit: 073ca1a |
cipolleschi
approved these changes
Feb 22, 2024
Contributor
|
can you please add a cherry pick request in the proper discussion? |
Contributor
Author
|
Added: reactwg/react-native-releases#104 (comment) So I should re-target this to main? |
Contributor
|
probably yes. |
okwasniewski
force-pushed
the
fix/properly-warn-deprecated-method
branch
from
3b3925a to
a18663c
Compare
okwasniewski
force-pushed
the
fix/properly-warn-deprecated-method
branch
from
a18663c to
5d9b8b2
Compare
Contributor
Author
|
@cipolleschi I've changed the target |
facebook-github-bot
added
the
Shared with Meta
cipolleschi
approved these changes
Feb 28, 2024
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
@cipolleschi merged this pull request in a119769. |
huntie
pushed a commit
that referenced
this pull request
Mar 4, 2024
Summary:
This PR fixes an issue that `_logWarnIfCreateRootViewWithBridgeIsOverridden` was called in wrong place.
Assuming user overrides this method and call to `[super]`:
```objc
- (UIView *)createRootViewWithBridge:(RCTBridge *)bridge moduleName:(NSString *)moduleName initProps:(NSDictionary *)initProps {
UIView *view = [super createRootViewWithBridge:bridge moduleName:moduleName initProps:initProps];
view.backgroundColor = [UIColor redColor];
return view;
}
```
This method still wasn't called in bridgeless (and not showing the error).
Checking if user overrides this method in `appDidFinishWithLaunching` works every time
## Changelog:
[IOS] [FIXED] - Properly warn about `createRootViewWithBridge` being deprecated
Pull Request resolved: #43146
Test Plan: Check if warning is shown when message is overridden
Reviewed By: huntie
Differential Revision: D54303506
Pulled By: cipolleschi
fbshipit-source-id: cf30555c791493f28b3015a189cf93b60cace8f8
okwasniewski
added a commit
to okwasniewski/react-native
that referenced
this pull request
Mar 5, 2024
…ok#43146) Summary: This PR fixes an issue that `_logWarnIfCreateRootViewWithBridgeIsOverridden` was called in wrong place. Assuming user overrides this method and call to `[super]`: ```objc - (UIView *)createRootViewWithBridge:(RCTBridge *)bridge moduleName:(NSString *)moduleName initProps:(NSDictionary *)initProps { UIView *view = [super createRootViewWithBridge:bridge moduleName:moduleName initProps:initProps]; view.backgroundColor = [UIColor redColor]; return view; } ``` This method still wasn't called in bridgeless (and not showing the error). Checking if user overrides this method in `appDidFinishWithLaunching` works every time  ## Changelog: [IOS] [FIXED] - Properly warn about `createRootViewWithBridge` being deprecated Pull Request resolved: facebook#43146 Test Plan: Check if warning is shown when message is overridden Reviewed By: huntie Differential Revision: D54303506 Pulled By: cipolleschi fbshipit-source-id: cf30555c791493f28b3015a189cf93b60cace8f8
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes an issue that
_logWarnIfCreateRootViewWithBridgeIsOverriddenwas called in wrong place.Assuming user overrides this method and call to
[super]:This method still wasn't called in bridgeless (and not showing the error).
Checking if user overrides this method in
appDidFinishWithLaunchingworks every timeChangelog:
[IOS] [FIXED] - Properly warn about
createRootViewWithBridgebeing deprecatedTest Plan:
Check if warning is shown when message is overridden