-
Notifications
You must be signed in to change notification settings - Fork 25k
Bump packages for next major release #43132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: I noticed inconsistent handling of terminating newlines in D54006327@V1, and had also been noticing `yarn build` reformatting unrelated sections of `package.json` files. For now, this logic isn't moved to a shared util, since there will likely be a higher level abstraction for the release scripts in the next batch of improvements. Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D54007565
Summary: Command run: ``` node scripts/releases/set-version 0.75.0-main --skip-react-native-version ``` Changelog: [Internal] Reviewed By: lunaleaps, cipolleschi Differential Revision: D54006327
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D54006327 |
Base commit: f3e132b |
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Mar 1, 2024
Summary:
Addresses a gap when using the `set-version` script to update all packages on `main` (i.e. post branch cut):
- Package versions were not being set consistently. It is safe to version all workspace packages, including `"private"`.
- Our publishing workflow is independent from this, and only considers public packages for submission to npm.
- We also need to update the root `package.json`, which includes `devDependencies` referencing workspace dependencies.
Unblocks facebook#43132.
Changelog: [Internal]
Differential Revision: D54419456
huntie
added a commit
to huntie/react-native
that referenced
this pull request
Mar 1, 2024
Summary:
Addresses a gap when using the `set-version` script to update all packages on `main` (i.e. post branch cut):
- Package versions were not being set consistently. It is safe to version all workspace packages, including `"private"`.
- Our publishing workflow is independent from this, and only considers public packages for submission to npm.
- We also need to update the root `package.json`, which includes `devDependencies` referencing workspace dependencies.
Unblocks facebook#43132.
Changelog: [Internal]
Differential Revision: D54419456
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
Summary:
Addresses a gap when using the `set-version` script to update all packages on `main` (i.e. post branch cut):
- Package versions were not being set consistently. It is safe to version all workspace packages, including `"private"`.
- Our publishing workflow is independent from this, and only considers public packages for submission to npm.
- We also need to update the root `package.json`, which includes `devDependencies` referencing workspace dependencies.
Unblocks #43132.
Changelog: [Internal]
Reviewed By: lunaleaps
Differential Revision: D54419456
fbshipit-source-id: 93eee669c5cf7c2f16b68a2bf41e9a8ace5521bf
Contributor
|
This pull request has been merged in f57be12. |
huntie
added a commit
that referenced
this pull request
Mar 18, 2024
Summary:
Addresses a gap when using the `set-version` script to update all packages on `main` (i.e. post branch cut):
- Package versions were not being set consistently. It is safe to version all workspace packages, including `"private"`.
- Our publishing workflow is independent from this, and only considers public packages for submission to npm.
- We also need to update the root `package.json`, which includes `devDependencies` referencing workspace dependencies.
Unblocks #43132.
Changelog: [Internal]
Reviewed By: lunaleaps
Differential Revision: D54419456
fbshipit-source-id: 93eee669c5cf7c2f16b68a2bf41e9a8ace5521bf
blakef
pushed a commit
to react-native-community/template
that referenced
this pull request
Jun 4, 2024
Summary: Pull Request resolved: facebook/react-native#43132 Command run: ``` node scripts/releases/set-version 0.75.0-main --skip-react-native-version ``` Changelog: [Internal] Reviewed By: lunaleaps, cipolleschi Differential Revision: D54006327 fbshipit-source-id: 7afe9e7ca3020faf399fdba2221fab8a102c56c7 Original: facebook/react-native@f57be12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Merged
This PR has been merged.
p: Facebook
Partner: Facebook
Partner
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Command run:
Changelog: [Internal]
Reviewed By: lunaleaps, cipolleschi
Differential Revision: D54006327