-
Notifications
You must be signed in to change notification settings - Fork 25k
added version specific websites #3459 #4234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Cool! How did you test this? |
website/publish.sh
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the value of VERSION if we're on master?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on branch 0.17-stable locally and this returns v0.3.11.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry it should have been git describe --abbrev=0 --tags
|
I sent initially to get some feedback as there were some clarifications. I commented out the Since there are docs in the current |
|
@udnisap updated the pull request. |
|
@udnisap updated the pull request. |
1 similar comment
|
@udnisap updated the pull request. |
|
Is the bot having some issues? I did not update the pull request for a while |
|
@udnisap Yeah. Ignore the bot. |
|
|
|
Thanks for the contribution, @udnisap. I'll close this PR though because the work will be coming from the internal codebase and will require some more back and forward review process. |
I only implemented the version specific docs. What are we going to do with the default docs and how to navigate between docs?