RN: Remove Deprecated Prop Types #42019
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Removes the following deprecated properties from React Native: - `Image.propTypes` - `Text.propTypes` - `TextInput.propTypes` - `ColorPropType` - `EdgeInsetsPropType` - `PointPropType` - `ViewPropTypes` The deprecation history for these prop types is not super obvious, so here is a summary: - `[email protected]` extracted `prop-types` into a separate package to reflect that not everybody uses them. - `[email protected]` added a deprecation warning to built-in prop types. (facebook@3f62904) - `[email protected]` removed built-in prop types. (facebook@3e229f2) - `[email protected]` restored built-in prop types, along with bug fixes to isolate deprecated usage. (facebook@b966d29) We believe that by the next public release, enough time will have passed for the community to be able to upgrade without patching React Native or otherwise working around the removal of these deprecated prop types. **If anyone has trouble identifying the source of a deleted prop types usage, please file an issue so we can help track it down with you.** Changelog: [General][Removed] - Removed deprecated prop types Differential Revision: D52337762
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D52337762 |
Base commit: dae4a11 |
Contributor
|
This pull request has been merged in 228cb80. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#42019 Removes the following deprecated properties from React Native: - `Image.propTypes` - `Text.propTypes` - `TextInput.propTypes` - `ColorPropType` - `EdgeInsetsPropType` - `PointPropType` - `ViewPropTypes` The deprecation history for these prop types is not super obvious, so here is a summary: - `[email protected]` extracted `prop-types` into a separate package to reflect that not everybody uses them. - `[email protected]` added a deprecation warning to built-in prop types. (facebook@3f62904) - `[email protected]` removed built-in prop types. (facebook@3e229f2) - `[email protected]` restored built-in prop types, along with bug fixes to isolate deprecated usage. (facebook@b966d29) We believe that by the next public release, enough time will have passed for the community to be able to upgrade without patching React Native or otherwise working around the removal of these deprecated prop types. **If anyone has trouble identifying the source of a deleted prop types usage, please file an issue so we can help track it down with you.** Changelog: [General][Removed] - Removed deprecated prop types Reviewed By: lunaleaps, NickGerleman Differential Revision: D52337762 fbshipit-source-id: 9731f7e1dec29f3df535ab75cc50bed001fdfa0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Removes the following deprecated properties from React Native:
Image.propTypesText.propTypesTextInput.propTypesColorPropTypeEdgeInsetsPropTypePointPropTypeViewPropTypesThe deprecation history for these prop types is not super obvious, so here is a summary:
[email protected]extractedprop-typesinto a separate package to reflect that not everybody uses them.[email protected]added a deprecation warning to built-in prop types. (3f62904)[email protected]removed built-in prop types. (3e229f2)[email protected]restored built-in prop types, along with bug fixes to isolate deprecated usage. (b966d29)We believe that by the next public release, enough time will have passed for the community to be able to upgrade without patching React Native or otherwise working around the removal of these deprecated prop types.
If anyone has trouble identifying the source of a deleted prop types usage, please file an issue so we can help track it down with you.
Changelog:
[General][Removed] - Removed deprecated prop types
Differential Revision: D52337762