put PR#41194 behind gating #41469
Closed
put PR#41194 behind gating #41469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51274859 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Nov 13, 2023
Summary: Changelog: [Internal] PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it Differential Revision: D51274859
philIip
force-pushed
the
export-D51274859
branch
from
f8388fe to
98bc2c7
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51274859 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51274859 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Nov 13, 2023
Summary: Changelog: [Internal] PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it Differential Revision: D51274859
philIip
force-pushed
the
export-D51274859
branch
from
98bc2c7 to
5bf00b7
Compare
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Nov 13, 2023
Summary: Changelog: [Internal] PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it Differential Revision: D51274859
philIip
force-pushed
the
export-D51274859
branch
from
5bf00b7 to
ad98668
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51274859 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Nov 14, 2023
Summary: Changelog: [Internal] PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it Differential Revision: D51274859
philIip
force-pushed
the
export-D51274859
branch
from
ad98668 to
8fa707b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51274859 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Nov 14, 2023
Summary: Changelog: [Internal] PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it Differential Revision: D51274859
philIip
force-pushed
the
export-D51274859
branch
from
8fa707b to
e8fdae6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51274859 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Nov 14, 2023
Summary: Changelog: [Internal] PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it Differential Revision: D51274859
philIip
force-pushed
the
export-D51274859
branch
from
e8fdae6 to
d7a664e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51274859 |
philIip
added a commit
to philIip/react-native
that referenced
this pull request
Nov 14, 2023
Summary: Changelog: [Internal] PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it Differential Revision: D51274859
philIip
force-pushed
the
export-D51274859
branch
from
d7a664e to
e1fba7e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51274859 |
Summary: Changelog: [Internal] PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it Differential Revision: D51274859
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D51274859 |
philIip
force-pushed
the
export-D51274859
branch
from
e1fba7e to
b4140ad
Compare
Contributor
|
This pull request has been merged in 8feb84a. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: Pull Request resolved: facebook#41469 Changelog: [Internal] PR#41194 (facebook#41194) introduces a new callsite to `RCTUnsafeExecuteOnMainQueueSync` in the module init path, which increases risk for deadlock. let's gate it Differential Revision: D51274859 fbshipit-source-id: b2ab6d42378d2885def1fdad61e1de0f6e6285cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
PR#41194 (#41194) introduces a new callsite to
RCTUnsafeExecuteOnMainQueueSyncin the module init path, which increases risk for deadlock. let's gate itDifferential Revision: D51274859