-
Notifications
You must be signed in to change notification settings - Fork 25k
feat(iOS) remove deprecated [UIScreen mainScreen] references #41388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iOS) remove deprecated [UIScreen mainScreen] references #41388
Conversation
… for FBSnapshotTestController
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes looks good to me. I'm importing it to see if tests pass, and to have another pair of eyes on this from the person who worked on this directly.
Base commit: c95b2d9 |
|
This pull request was successfully merged by @okwasniewski in 88e3913. When will my fix make it into a release? | Upcoming Releases |
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks ## Changelog: [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
…k#41388) Summary: The goal for this PR is to further remove references for `[UIScreen mainScreen]` and migrate them to use trait collections. This helps out of tree platforms like visionOS (where the `UIScreen` is not available). bypass-github-export-checks [INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m [IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView Pull Request resolved: facebook#41388 Test Plan: – Check if tests passes - Check if `RCTDevLoadingView` shows up correctly. Screenshot:  Reviewed By: javache Differential Revision: D51156230 Pulled By: cipolleschi fbshipit-source-id: bbe711e0281046a082fd1680b55e2d117915ad00
Summary:
The goal for this PR is to further remove references for
[UIScreen mainScreen]and migrate them to use trait collections. This helps out of tree platforms like visionOS (where theUIScreenis not available).Changelog:
[INTERNAL] [CHANGED] - use currentTraitCollection for FBSnapshotTestController.m
[IOS] [CHANGED] - use key window width to assign the correct width for RCTDevLoadingView
Test Plan:
– Check if tests passes
RCTDevLoadingViewshows up correctly.Screenshot:
