Insets no longer apply to statically positioned nodes #41369
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50507808 |
Base commit: 974e584 |
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 8, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50507808 |
joevilches
force-pushed
the
export-D50507808
branch
from
1c01233 to
822e184
Compare
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 8, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
force-pushed
the
export-D50507808
branch
from
822e184 to
43eff8f
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50507808 |
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 14, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
force-pushed
the
export-D50507808
branch
from
43eff8f to
de21053
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50507808 |
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Nov 15, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
force-pushed
the
export-D50507808
branch
from
9a408d3 to
266cfa1
Compare
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50507808 |
joevilches
force-pushed
the
export-D50507808
branch
from
266cfa1 to
8bf945e
Compare
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50507808 |
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
force-pushed
the
export-D50507808
branch
from
8bf945e to
c5b4bfd
Compare
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50507808 |
joevilches
pushed a commit
to joevilches/yoga
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
joevilches
pushed a commit
to joevilches/react-native
that referenced
this pull request
Dec 4, 2023
Summary: X-link: facebook/yoga#1454 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808
facebook-github-bot
pushed a commit
to facebook/litho
that referenced
this pull request
Dec 5, 2023
Summary: X-link: facebook/yoga#1454 X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808 fbshipit-source-id: 7aab4138b06e60936db0ddb6019a9a30f1ded2db
|
This pull request was successfully merged by @joevilches in e48da2a. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
This pull request has been merged in e48da2a. |
facebook-github-bot
pushed a commit
to facebook/yoga
that referenced
this pull request
Dec 5, 2023
Summary: Pull Request resolved: #1454 X-link: facebook/react-native#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808 fbshipit-source-id: 7aab4138b06e60936db0ddb6019a9a30f1ded2db
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: X-link: facebook/yoga#1454 Pull Request resolved: facebook#41369 One of the most basic aspects of statically positioned nodes is that [insets do not apply to them](https://developer.mozilla.org/en-US/docs/Web/CSS/position#static). So I put a guard inside `Node::relativePosition` where we take that into account when setting the position. Reviewed By: NickGerleman Differential Revision: D50507808 fbshipit-source-id: 7aab4138b06e60936db0ddb6019a9a30f1ded2db
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: One of the most basic aspects of statically positioned nodes is that insets do not apply to them. So I put a guard inside
Node::relativePositionwhere we take that into account when setting the position.Differential Revision: D50507808