Refactor softInputMode check in ReactRootView.java
#40970
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50297761 |
Base commit: 4466001 |
kot331107
reviewed
Oct 14, 2023
| } else { | ||
| return; | ||
| } | ||
| ViewGroup.LayoutParams rootLayoutParams = getRootView().getLayoutParams(); |
Contributor
|
@NickGerleman yes, it works in my app and looks much better then drilling |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50297761 |
Summary: This cleans up facebook@9497203 a bit, after I did some debugging and looking through Android source code. 1. `getRootView()` gives us constant-time access to root hierarchy, and we don't need to do instanceof check once per level. It also, at least in the sample activity I tried, gives us the Window's `LayoutParams`. 2. The root of the hierarchy is documented in code to do what we want. facebook@9497203 3. Calling `getRootView().getLayoutParams()`, then casting to `WindowManager.LayoutParams`, seems to show up in a lot of other widgets (inc Unity, RoboElectric), as a solution to getting this information. https://github.com/search?q=getRootView%28%29.getLayoutParams%28%29&type=code This still feels like not a 100% documented contract, so I added an assertion so we can catch if the contract isn't valid somewhere now or in the future, instead of silently breaking keyboard events. Note that this code only runs on SDK 30+ (Android 11+). Changelog: [Internal] Reviewed By: javache Differential Revision: D50297761
NickGerleman
force-pushed
the
export-D50297761
branch
from
95ec4d3 to
8560c12
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D50297761 |
Contributor
|
This pull request has been merged in bb9cc0c. |
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Oct 30, 2023
Summary: Pull Request resolved: facebook#40970 This cleans up facebook@9497203 a bit, after I did some debugging and looking through Android source code. 1. `getRootView()` gives us constant-time access to root hierarchy, and we don't need to do instanceof check once per level. It also, at least in the sample activity I tried, gives us the Window's `LayoutParams`. 2. The root of the hierarchy is documented in code to do what we want. facebook@9497203 3. Calling `getRootView().getLayoutParams()`, then casting to `WindowManager.LayoutParams`, seems to show up in a lot of other widgets (inc Unity, RoboElectric), as a solution to getting this information. https://github.com/search?q=getRootView%28%29.getLayoutParams%28%29&type=code This still feels like not a 100% documented contract, so I added an assertion so we can catch if the contract isn't valid somewhere now or in the future, instead of silently breaking keyboard events. Note that this code only runs on SDK 30+ (Android 11+). Changelog: [Internal] Reviewed By: javache Differential Revision: D50297761 fbshipit-source-id: f97fb6ea1bcdb1b8e8dfcdcc178625efc0bb6b4a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This cleans up 9497203 a bit, after I did some debugging and looking through Android source code.
getRootView()gives us constant-time access to root hierarchy, and we don't need to do instanceof check once per level. It also, at least in the sample activity I tried, gives us the Window'sLayoutParams.getRootView().getLayoutParams(), then casting toWindowManager.LayoutParams, seems to show up in a lot of other widgets (inc Unity, RoboElectric), as a solution to getting this information. https://github.com/search?q=getRootView%28%29.getLayoutParams%28%29&type=codeThis still feels like not a 100% documented contract, so I added an assertion so we can catch if the contract isn't valid somewhere now or in the future, instead of silently breaking keyboard events.
Note that this code only runs on SDK 30+ (Android 11+).
Test Plan
On Android API 34 emulator, set an explicit
windowSoftInputModeforRNTesterActivityand check the keyboard events page run viabuck install rntester-android.adjustResize(RN default)adjustPanadjustNothingDifferential Revision: D50297761