Skip to content

Remove i386 arch check for Hermes #40656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Sunbreak wants to merge 1 commit into from
Closed

Remove i386 arch check for Hermes #40656

Sunbreak wants to merge 1 commit into from
+2 −116

Conversation

@Sunbreak
Copy link
Contributor

@Sunbreak Sunbreak commented Oct 8, 2023

Summary:

Since 21763e8, min_ios_version_supported is 13.4. So i386 is no longer supported as iOS(maybe tvOS) target architecture

Changelog:

[IOS] [INTERNAL] - remove exclude_i386_architecture_while_using_hermes

Test Plan:

None

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 8, 2023
@analysis-bot
Copy link

analysis-bot commented Oct 8, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,227,279 +8
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,599,507 -4
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 60f5a80
Branch: main

cipolleschi
cipolleschi approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Sunbreak, thanks for this PR. I'll try to land it!

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Oct 10, 2023

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

This pull request was successfully merged by @Sunbreak in 39bbf8c.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Oct 10, 2023
@Sunbreak Sunbreak deleted the rm-i386-hermes branch October 11, 2023 08:20
@Sunbreak
Copy link
Contributor Author

Sunbreak commented Oct 11, 2023

Hi @Sunbreak, thanks for this PR. I'll try to land it!

BTW any arm-32bit support is unused as well

@ken0nek ken0nek mentioned this pull request Feb 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sunbreak @analysis-bot @facebook-github-bot @cipolleschi