Skip to content

Conversation

@NickGerleman
Copy link
Contributor

@NickGerleman NickGerleman commented Oct 4, 2023

This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Oct 4, 2023
@facebook-github-bot
Copy link
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented Oct 4, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 16,685,388 -208,932
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,164,124 -208,928
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 7d88ac4
Branch: main

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Warnings
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
⚠️

Can't find the E2E test log for ci/circleci: test_e2e_ios. Job link

⚠️

Can't find the E2E test log for ci/circleci: test_e2e_ios. Job link

Generated by 🚫 dangerJS against a7535db

@facebook-github-bot
Copy link
Contributor

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 4, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]


Test Plan: Passes in CircleCI

Differential Revision: D49900112

Pulled By: NickGerleman
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49900112

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 4, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: 41ef4811e4ab9c79b53011514b39b1450c24fd73
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 4, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: e1f3e8ca894c3d783bd581a9971337fc372d08cb
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 4, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: 274110f7a832f39ffa4260789666082ba9f1022c
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 4, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: 46569a22ac2a6ce44a3afb08f117d79eb98416c2
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49900112

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 4, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]


Test Plan: Passes in CircleCI

Reviewed By: yungsters

Differential Revision: D49900112

Pulled By: NickGerleman
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 4, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: 585c7d33e38c135d0c315d5276f0eec97ed4217f
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 4, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: 329e29d679780f37c3818e7aa086bfe870ddd2c5
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 4, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: 03922c435ff6f9995358138b5ba1ce2fa0b8567c
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 4, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: 47bc2dc545871e9a9c1273e11359fd286e460c69
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 4, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: d48d8aebd22eb743bcdb2f7b307e1a45425fb7c9
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 4, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: c1785626fa5576879f90deab220964f2d565fd24
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 4, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: 77391effcfc10ec46a2d238e808a12578b20585a
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0


Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49900112

NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 5, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: eb3cb53743560cd24552479a3cbc5d84b2a7aa8d
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 5, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: 68bd2b951f147b23dabee338d9b5e81e3294977a
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 5, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: 61dd5711a78494607370dc92de00726b0301225a
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 5, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: 92a3582bbddbb310ec1f4e61b57960ca10c6beb8
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 5, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: cfcca6803983a711f09cfa0bc399d0b29d9ff97c
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 5, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: e451d339f35c3ef9d1aca6fafde58b4cc73d6e47
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 5, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: 502293fd4a467d1df447bef6d50a42065d167092
NickGerleman added a commit to NickGerleman/react-native that referenced this pull request Oct 5, 2023
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog: [Internal]

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Differential Revision: D49900112

fbshipit-source-id: f33f9684d0836530409a553bb4c88bbc082a1f57
@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Oct 5, 2023
@facebook-github-bot
Copy link
Contributor

@NickGerleman merged this pull request in bb9ed0e.

Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 17, 2024
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 17, 2024
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 20, 2024
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 20, 2024
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 20, 2024
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 20, 2024
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 20, 2024
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 20, 2024
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd
Saadnajmi added a commit to microsoft/react-native-macos that referenced this pull request Jan 23, 2024
…2049)

* [visionOS] Add local podspecs to override supported platforms

* Bump fmt to 9.1.0 (facebook#39799)

Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd

---------

Co-authored-by: Nick Gerleman <[email protected]>
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 23, 2024
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd
Saadnajmi added a commit to microsoft/react-native-macos that referenced this pull request Jan 23, 2024
…2048)

* [visionOS] Add local podspecs to override supported platforms

* Bump fmt to 9.1.0 (facebook#39799)

Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd

* [CI] Install the latest version of packages in the brewfile (#2024)

* [CI] Remove watchman

---------

Co-authored-by: Nick Gerleman <[email protected]>
okwasniewski pushed a commit to callstack/react-native-visionos that referenced this pull request Jan 31, 2024
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd

# Conflicts:
#	packages/react-native/ReactCommon/react/nativemodule/samples/ReactCommon-Samples.podspec
#	packages/react-native/ReactCommon/react/renderer/debug/React-rendererdebug.podspec
#	packages/rn-tester/Podfile.lock
okwasniewski pushed a commit to callstack/react-native-visionos that referenced this pull request Feb 6, 2024
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd

# Conflicts:
#	packages/react-native/ReactCommon/react/nativemodule/samples/ReactCommon-Samples.podspec
#	packages/react-native/ReactCommon/react/renderer/debug/React-rendererdebug.podspec
#	packages/rn-tester/Podfile.lock
okwasniewski pushed a commit to callstack/react-native-visionos that referenced this pull request Apr 5, 2024
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd

# Conflicts:
#	packages/react-native/ReactCommon/react/nativemodule/samples/ReactCommon-Samples.podspec
#	packages/react-native/ReactCommon/react/renderer/debug/React-rendererdebug.podspec
#	packages/rn-tester/Podfile.lock
okwasniewski pushed a commit to callstack/react-native-visionos that referenced this pull request Jun 24, 2024
Summary:
This is what Folly is built against internally. Bump the version we use, and the standard we compile with, to take some different paths, and see if we fix some warnings caused by FMT with the ndk bump.

Changelog:
[General][Breaking] - Bump fmt to 9.1.0

Pull Request resolved: facebook#39799

Test Plan: Passes in CircleCI

Reviewed By: cortinico, yungsters

Differential Revision: D49900112

Pulled By: NickGerleman

fbshipit-source-id: 3f11080555ef20aeb9291d1096ffa6077b3b3bbd

# Conflicts:
#	packages/react-native/ReactCommon/react/nativemodule/samples/ReactCommon-Samples.podspec
#	packages/react-native/ReactCommon/react/renderer/debug/React-rendererdebug.podspec
#	packages/rn-tester/Podfile.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants