Skip to content

feat: add ValueUnit struct #39150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
intergalacticspacehighway wants to merge 2 commits into from
Closed

feat: add ValueUnit struct #39150

intergalacticspacehighway wants to merge 2 commits into from

Conversation

@intergalacticspacehighway
Copy link
Contributor

@intergalacticspacehighway intergalacticspacehighway commented Aug 24, 2023 •
edited
Loading

Summary:

Adds a new struct ValueUnit for #38559. This is a simple version of YGValue struct to hold values that have percentage and point as units.

Changelog:

[INTERNAL] [ADDED] - ValueUnit struct

Test Plan:

Pod install and build the rn-tester ios app

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Aug 24, 2023
@intergalacticspacehighway intergalacticspacehighway mentioned this pull request Aug 24, 2023
Closed
@analysis-bot
Copy link

analysis-bot commented Aug 24, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,959,324 -210
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 9,554,403 +104
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 8955bfb
Branch: main

@lunaleaps lunaleaps requested a review from NickGerleman August 24, 2023 18:51
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Aug 25, 2023

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@javache
Copy link
Member

javache commented Aug 25, 2023

I think this PR should be "stacked" on the other transform-origin changes, so it can be introduced with an immediate use-case.

@intergalacticspacehighway
Copy link
Contributor Author

intergalacticspacehighway commented Aug 25, 2023

@javache merged this branch here - 0f27a0c and usage - a30ed3d. Feel free to close this PR!

@intergalacticspacehighway intergalacticspacehighway deleted the feat/add-value-unit-struct branch August 9, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickGerleman NickGerleman NickGerleman left review comments

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@intergalacticspacehighway @analysis-bot @facebook-github-bot @javache @NickGerleman