Skip to content

Conversation

@Gregoirevda
Copy link
Contributor

Summary:

Adding equivalent of existing DrawerLayoutAndroid.
I'm using the method added in PR #37873 for AppDelegate too only contain enhancements.
Native Drawer, with gestures and button to open and close.
It does have issues:

  • Can't make flex-1 work within DrawerLayoutIos children. DrawerLayoutIos needs to have a specific width and height. Can't bound it to the drawer full size.
  • Children of DrawerLayoutIos are correctly rendered and updated in the drawer, but they are also rendered within the current tree
Screenshot 2023-06-15 at 23 50 46

Changelog:

IOS ADDED - Adding LayoutDrawerIos

Test Plan:

Tested on simulator iPad Pro iOS 16.2

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 15, 2023
@github-actions
Copy link

Fails
🚫

📋 Verify Changelog Format - A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Generated by 🚫 dangerJS against 36d641e

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,545,460 -212,223
android hermes armeabi-v7a 7,859,635 -210,624
android hermes x86 9,024,364 -225,915
android hermes x86_64 8,878,909 -220,509
android jsc arm64-v8a 9,145,059 -173,776
android jsc armeabi-v7a 8,335,015 -173,727
android jsc x86 9,198,316 -184,005
android jsc x86_64 9,455,900 -179,662

Base commit: 2ae163a
Branch: main

@Pranav-yadav
Copy link
Contributor

Since this is a feat, you should be targeting main and not 0.72-stable; the current working branch should also be checked out from main only.
And after this is merged into the main team can pick it into other stable branches if needed 👍

P.S.: I may be unaware of the whole context here so you should wait for a review from the team :)


This is awesome 🚀


Other tips:

  1. Change the changelog to the format suggested here: feat: LayoutDrawerIos #37924 (comment)
  2. You may run yarn prettier && yarn lint

@Gregoirevda
Copy link
Contributor Author

Closing and re-opening #37928 targeting main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Pick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants