Update Node.js to v18 in all RN packages #37791
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 9, 2023
Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: NickGerleman Differential Revision: D46583997 fbshipit-source-id: 137066bf6d593cea4b8540051525f21406ea81cb
arushikesarwani94
force-pushed
the
export-D46583997
branch
from
18d095b to
2db2f23
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 9, 2023
Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: NickGerleman Differential Revision: D46583997 fbshipit-source-id: e9b9501a11745797e26c761f5957d124f73e143c
arushikesarwani94
force-pushed
the
export-D46583997
branch
from
2db2f23 to
85b2857
Compare
Contributor
|
@cortinico, @kelset just "curious" which version this bump to |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 13, 2023
Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: NickGerleman Differential Revision: D46583997 fbshipit-source-id: 5d2d70a76cc1c52098d7837b5413815802f01716
arushikesarwani94
force-pushed
the
export-D46583997
branch
from
85b2857 to
6dcdd6c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
arushikesarwani94
force-pushed
the
export-D46583997
branch
from
6dcdd6c to
65a9d3c
Compare
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 13, 2023
Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: NickGerleman Differential Revision: D46583997 fbshipit-source-id: b1eeec164052548ba94a118df90bc9e99025a194
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
arushikesarwani94
force-pushed
the
export-D46583997
branch
from
65a9d3c to
d97b0a1
Compare
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 13, 2023
Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: NickGerleman Differential Revision: D46583997 fbshipit-source-id: a4c7ff54c7762c8b6edb0b9a5634ae1243e378e3
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
Contributor
We'll probably end up bumping |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 15, 2023
Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: NickGerleman Differential Revision: D46583997 fbshipit-source-id: 543973a13f130c29685d8cf38247fa509fc52934
arushikesarwani94
force-pushed
the
export-D46583997
branch
from
d97b0a1 to
2f1cd05
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
cortinico
approved these changes
Jun 15, 2023
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 15, 2023
Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: NickGerleman Differential Revision: D46583997 fbshipit-source-id: 03802038051aa52f70bb44cca150ea50989d932e
arushikesarwani94
force-pushed
the
export-D46583997
branch
from
2f1cd05 to
5ad8e87
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 20, 2023
Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: cortinico, NickGerleman Differential Revision: D46583997 fbshipit-source-id: 40e7f49d4abcb176563974ddd8fb71ba878cffd6
arushikesarwani94
force-pushed
the
export-D46583997
branch
from
5ad8e87 to
7d01b33
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 20, 2023
Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: cortinico, NickGerleman Differential Revision: D46583997 fbshipit-source-id: cd7e08cb653f8b66bad7662ca8564053acba1301
arushikesarwani94
force-pushed
the
export-D46583997
branch
from
7d01b33 to
cae7e24
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 20, 2023
Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: cortinico, NickGerleman Differential Revision: D46583997 fbshipit-source-id: 522545ce15bfae1e34268a003bf49e5c73692309
arushikesarwani94
force-pushed
the
export-D46583997
branch
from
cae7e24 to
26e109d
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 21, 2023
Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: cortinico, NickGerleman Differential Revision: D46583997 fbshipit-source-id: 4041dd0a4b6bb94eeccc9b4a685d5fca06ab5175
arushikesarwani94
force-pushed
the
export-D46583997
branch
from
26e109d to
6a43e62
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 21, 2023
Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: cortinico, NickGerleman Differential Revision: D46583997 fbshipit-source-id: 2d21d9283eca7109e9f4593bf60931f5ffc9ee56
arushikesarwani94
force-pushed
the
export-D46583997
branch
from
6a43e62 to
dc2948a
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
arushikesarwani94
added a commit
to arushikesarwani94/react-native
that referenced
this pull request
Jun 21, 2023
Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: cortinico, NickGerleman Differential Revision: D46583997 fbshipit-source-id: aa67de9670deb67dd2ab4c064cc074cade36a030
arushikesarwani94
force-pushed
the
export-D46583997
branch
from
dc2948a to
4429ddb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
Summary: Changelog: [General] [Fixed] - Update node version in `prepare_hermes_workspace` Differential Revision: D46905458 fbshipit-source-id: b859e40edfc4771b0467932b1e9eeefea7afaca1
Summary: ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16's EOL is 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ - this follows up by formally making Node 18 the minimum supported version. Docs PR: facebook/react-native-website#3748 Changelog: [General][Breaking] Bump minimum Node JS version to 18 Differential Revision: D46462639 fbshipit-source-id: 1b2ab0b9646a8aee0c66149deaa14d417eeb0b45
Summary: Pull Request resolved: facebook#37791 ## Bump minimum Node JS version to 18 via `react-native/package.json#engines` In facebook#35443 we bumped up the node version from 16 to 18. Node 16 [ends maintenance releases on 2023-09-11](https://nodejs.org/en/blog/announcements/nodejs16-eol/), and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden. This follows up by formally making Node 18 the minimum supported version. **Docs PR:** facebook/react-native-website#3748 **Changelog:** [General][Breaking] Bump minimum Node JS version to 18 Reviewed By: cortinico, NickGerleman Differential Revision: D46583997 fbshipit-source-id: b6fb7d884a885d1913a281e4ac5af830ab4bed4e
arushikesarwani94
force-pushed
the
export-D46583997
branch
from
4429ddb to
fa885d3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D46583997 |
Contributor
|
This pull request has been merged in 2eb25cb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Bump minimum Node JS version to 18 via
react-native/package.json#enginesIn #35443 we bumped up the node version from 16 to 18.
Node 16 ends maintenance releases on 2023-09-11, and bumping this minimum will allow other associated Node JS tools (CLI, Metro, Jest) to reduce their support burden.
This follows up by formally making Node 18 the minimum supported version.
Docs PR:
facebook/react-native-website#3748
Changelog:
[General][Breaking] Bump minimum Node JS version to 18
Differential Revision: D46583997