Parser create getTypeAnnotationName(typeAnnotation) #37580
Conversation
facebook-github-bot
added
the
CLA Signed
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Changes looks good to me, but CI is red. Could you try rebase on top of main and see whether the CI passes?
cloudpresser
force-pushed
the
cloudpresser/parser-get-type-annotation-name
branch
from
03b99dc to
4792837
Compare
Base commit: 0191d16 |
cloudpresser
force-pushed
the
cloudpresser/parser-get-type-annotation-name
branch
from
d76c730 to
b240a29
Compare
|
@cipolleschi I updated this PR with changes suggested here. |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| parser: Parser, | ||
| ): NamedShape<EventTypeAnnotation> { | ||
| const type = parser.extractTypeFromTypeAnnotation(typeAnnotation); | ||
|
|
There was a problem hiding this comment.
- 🚫 packages/react-native-codegen/src/parsers/flow/components/events.js line 46 – Delete
⏎(prettier/prettier)
| parser: Parser, | ||
| ): EventTypeAnnotation { | ||
| const type = parser.extractTypeFromTypeAnnotation(typeAnnotation); | ||
|
|
There was a problem hiding this comment.
- 🚫 packages/react-native-codegen/src/parsers/flow/components/events.js line 106 – Replace
⏎··const·type·=·extractTypeFromTypeAnnotation(typeAnnotation,·parser);⏎with··const·type·=·extractTypeFromTypeAnnotation(typeAnnotation,·parser);(prettier/prettier)
|
|
||
| function prettify(jsonObject: $FlowFixMe): string { | ||
| return JSON.stringify(jsonObject, null, 2); | ||
| } |
There was a problem hiding this comment.
- 🚫 packages/react-native-codegen/src/parsers/flow/components/events.js line 171 – Delete
⏎(prettier/prettier)
|
@cloudpresser I'm sorry to ask for this, I have been tried to land this change for a while, but meanwhile the state of the repo has changed. |
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
CI is red, unfortunately. :(
|
/rebase |
|
@cipolleschi merged this pull request in e22d1a1. |
5 participants
Summary:
This is part of #34872
Changelog:
[INTERNAL] [ADDED] - getTypeAnnotationName(typeAnnotation) in parser
Test Plan:
yarn jest packages/react-native-codegen> new tests written, as well as coverage from existing tests