Skip to content

Conversation

@dmytrorykun
Copy link
Contributor

Summary:
This diff adds cross-platform Cxx binding helper and iOS specific implementation of __nativeComponentRegistry__getNativeViewConfig to JS runtime. This function provides native view config for a native component in bridgeless mode.

Changelog:
[Internal] - Introduce __nativeComponentRegistry__getNativeViewConfig in iOS.

Differential Revision: D43538804

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels May 22, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43538804

@analysis-bot
Copy link

analysis-bot commented May 22, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,744,783 +0
android hermes armeabi-v7a 8,056,412 +0
android hermes x86 9,235,927 +2
android hermes x86_64 9,086,824 -2
android jsc arm64-v8a 9,307,488 +1
android jsc armeabi-v7a 8,496,710 +1
android jsc x86 9,369,696 +0
android jsc x86_64 9,624,714 +2

Base commit: 5eadd93
Branch: main

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request May 23, 2023
)

Summary:
Pull Request resolved: facebook#37522

This diff adds cross-platform Cxx binding helper and iOS specific implementation of `__nativeComponentRegistry__getNativeViewConfig` to JS runtime. This function provides native view config for a native component in bridgeless mode.

Changelog:
[Internal] - Introduce `__nativeComponentRegistry__getNativeViewConfig` in iOS.

Differential Revision: D43538804

fbshipit-source-id: 1e8c23ab36daaac13b38ee4b37f7971cf7d35fbb
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43538804

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request May 23, 2023
)

Summary:
Pull Request resolved: facebook#37522

This diff adds cross-platform Cxx binding helper and iOS specific implementation of `__nativeComponentRegistry__getNativeViewConfig` to JS runtime. This function provides native view config for a native component in bridgeless mode.

Changelog:
[Internal] - Introduce `__nativeComponentRegistry__getNativeViewConfig` in iOS.

Differential Revision: D43538804

fbshipit-source-id: 8002bc6c88718e2d0f4d5cd7816c0c81175def69
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43538804

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43538804

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request May 24, 2023
)

Summary:
Pull Request resolved: facebook#37522

This diff adds cross-platform Cxx binding helper and iOS specific implementation of `__nativeComponentRegistry__getNativeViewConfig` to JS runtime. This function provides native view config for a native component in bridgeless mode.

Changelog:
[Internal] - Introduce `__nativeComponentRegistry__getNativeViewConfig` in iOS.

Differential Revision: D43538804

fbshipit-source-id: 99c9c10a1faa396bf3f87650a2e9d0b65666708c
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43538804

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request May 24, 2023
)

Summary:
Pull Request resolved: facebook#37522

This diff adds cross-platform Cxx binding helper and iOS specific implementation of `__nativeComponentRegistry__getNativeViewConfig` to JS runtime. This function provides native view config for a native component in bridgeless mode.

Changelog:
[Internal] - Introduce `__nativeComponentRegistry__getNativeViewConfig` in iOS.

Differential Revision: D43538804

fbshipit-source-id: e45f34164e76f28b66bb3cb16096619fa8384d2e
@dmytrorykun dmytrorykun force-pushed the export-D43538804 branch 2 times, most recently from 75e76ff to d903dc4 Compare May 25, 2023 16:02
dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request May 25, 2023
)

Summary:
Pull Request resolved: facebook#37522

This diff adds cross-platform Cxx binding helper and iOS specific implementation of `__nativeComponentRegistry__getNativeViewConfig` to JS runtime. This function provides native view config for a native component in bridgeless mode.

Changelog:
[Internal] - Introduce `__nativeComponentRegistry__getNativeViewConfig` in iOS.

Differential Revision: D43538804

fbshipit-source-id: a4dd3f28d4fa157a6eb9ebb31d5c1a85ad7b7b1d
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43538804

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request May 25, 2023
)

Summary:
Pull Request resolved: facebook#37522

This diff adds cross-platform Cxx binding helper and iOS specific implementation of `__nativeComponentRegistry__getNativeViewConfig` to JS runtime. This function provides native view config for a native component in bridgeless mode.

Changelog:
[Internal] - Introduce `__nativeComponentRegistry__getNativeViewConfig` in iOS.

Differential Revision: D43538804

fbshipit-source-id: 1d7b4e379e657cfe8bfd3ba0592e7e13ae7501c3
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43538804

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request May 26, 2023
)

Summary:
Pull Request resolved: facebook#37522

This diff adds cross-platform Cxx binding helper and iOS specific implementation of `__nativeComponentRegistry__getNativeViewConfig` to JS runtime. This function provides native view config for a native component in bridgeless mode.

Changelog:
[Internal] - Introduce `__nativeComponentRegistry__getNativeViewConfig` in iOS.

Reviewed By: javache

Differential Revision: D43538804

fbshipit-source-id: a0a31d20f9061e2b9223965aa26380a9e6118ded
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43538804

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43538804

dmytrorykun added a commit to dmytrorykun/react-native that referenced this pull request May 30, 2023
)

Summary:
Pull Request resolved: facebook#37522

This diff adds cross-platform Cxx binding helper and iOS specific implementation of `__nativeComponentRegistry__getNativeViewConfig` to JS runtime. This function provides native view config for a native component in bridgeless mode.

Changelog:
[Internal] - Introduce `__nativeComponentRegistry__getNativeViewConfig` in iOS.

Reviewed By: javache

Differential Revision: D43538804

fbshipit-source-id: c4fc7d6d2e4543ddb5cedf7ed4d3ef6a12b2fccf
)

Summary:
Pull Request resolved: facebook#37522

This diff adds cross-platform Cxx binding helper and iOS specific implementation of `__nativeComponentRegistry__getNativeViewConfig` to JS runtime. This function provides native view config for a native component in bridgeless mode.

Changelog:
[Internal] - Introduce `__nativeComponentRegistry__getNativeViewConfig` in iOS.

Reviewed By: javache

Differential Revision: D43538804

fbshipit-source-id: 025f19038eee22c1992dded190d6f265ff1f8a01
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D43538804

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 7f22db8.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 30, 2023
@dmytrorykun dmytrorykun deleted the export-D43538804 branch June 2, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants