Skip to content

Conversation

@Shubham1429
Copy link

Summary:

part of codegen issue #34872

Add an undefinedLiteralTypeAnnotation: string property into the Parser object and implement it in the FlowParser (returning VoidLiteralTypeAnnotation) and in the TypeScriptPArser(returning TSUndefinedKeyword). Replace them in and parsers/typescript/components/events.js.

Changelog:

[Internal][Added]: Add undefinedLiteralTypeAnnotation property in parsers

Test Plan:

yarn test

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 16, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you so much for this!

@analysis-bot
Copy link

analysis-bot commented May 16, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,739,375 -4
android hermes armeabi-v7a 8,050,275 +2
android hermes x86 9,229,566 -2
android hermes x86_64 9,081,396 +0
android jsc arm64-v8a 9,302,721 -2
android jsc armeabi-v7a 8,491,197 -1
android jsc x86 9,363,976 -1
android jsc x86_64 9,619,916 -1

Base commit: 670fa88
Branch: main

@Shubham1429 Shubham1429 force-pushed the add-undefinedLiteralTypeAnnotation-property-in-parser branch from bb34076 to c229715 Compare May 17, 2023 11:25
@Pranav-yadav Pranav-yadav added the Tech: Codegen Related to react-native-codegen label May 17, 2023
@cipolleschi
Copy link
Contributor

/rebase

@github-actions github-actions bot force-pushed the add-undefinedLiteralTypeAnnotation-property-in-parser branch from c229715 to 78373ab Compare May 22, 2023 09:04
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@Pranav-yadav
Copy link
Contributor

Hi @Shubham1429, 👋

Congratulations 🎉 on your "First Pull Request" to React Native! 🥳

Thank you, 🙏 for taking the time to contribute to this project and share your ideas.

Someone from the team will review your PR and get back to you as soon as possible with feedback if any. 😊 Post review, and if all tests are passing, your PR will be imported to internal FB phabricator and should be "merged" if it also passes all internal tests. 🥳


Contributing Guidelines | React Native Website | Framework discussions, proposals and RFCs

@cipolleschi
Copy link
Contributor

Hi @Shubham1429! Can I ask you to rebase and resolve conflicts, please? With more people working on Codegen is normal to have to spend some time in this kind of tasks. Thanks!

@Shubham1429 Shubham1429 force-pushed the add-undefinedLiteralTypeAnnotation-property-in-parser branch from 78373ab to 3183eae Compare May 24, 2023 08:16
@facebook-github-bot
Copy link
Contributor

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 25, 2023
@facebook-github-bot
Copy link
Contributor

@cipolleschi merged this pull request in cf8184d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Tech: Codegen Related to react-native-codegen

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants