-
Notifications
You must be signed in to change notification settings - Fork 25k
refactor(codegen): add undefinedLiteralTypeAnnotation prop in parsers #37450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(codegen): add undefinedLiteralTypeAnnotation prop in parsers #37450
Conversation
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cipolleschi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you so much for this!
Base commit: 670fa88 |
bb34076 to
c229715
Compare
|
/rebase |
c229715 to
78373ab
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Hi @Shubham1429, 👋Congratulations 🎉 on your "First Pull Request" to React Native! 🥳Thank you, 🙏 for taking the time to contribute to this project and share your ideas. Someone from the team will review your PR and get back to you as soon as possible with feedback if any. 😊 Post review, and if all tests are passing, your PR will be imported to internal FB phabricator and should be "merged" if it also passes all internal tests. 🥳 Contributing Guidelines | React Native Website | Framework discussions, proposals and RFCs |
|
Hi @Shubham1429! Can I ask you to rebase and resolve conflicts, please? With more people working on Codegen is normal to have to spend some time in this kind of tasks. Thanks! |
78373ab to
3183eae
Compare
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@cipolleschi merged this pull request in cf8184d. |
Summary:
part of codegen issue #34872
Changelog:
[Internal][Added]: Add undefinedLiteralTypeAnnotation property in parsers
Test Plan:
yarn test