Skip to content

Conversation

@lunaleaps
Copy link
Contributor

#35692)"

This reverts commit 9669c10.

We'll be adding this in 0.73 when there's support for both the legacy renderer

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 2, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

Fails
🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

Warnings
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against 08fc618

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,543,533 -84,997
android hermes armeabi-v7a 7,858,074 -82,563
android hermes x86 9,022,592 -92,770
android hermes x86_64 8,877,849 -92,183
android jsc arm64-v8a 9,144,357 -48,240
android jsc armeabi-v7a 8,334,946 -47,209
android jsc x86 9,198,154 -52,622
android jsc x86_64 9,456,162 -52,945

Base commit: 99f88ce
Branch: main

@kelset kelset merged commit 840db21 into facebook:0.72-stable May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner Pick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants