Separate buffering per entry type in WebPerformance #36737
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44574241 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Mar 31, 2023
Summary: Pull Request resolved: facebook#36737 ## Changelog: [Internal] - Use `BoundedConsumableBuffer` in WebPerformance This makes use of the `BoundedConsumableBuffer` container type, introduced in D44544057, for buffering/observing arbitrary performance entry types in `WebPerformance/PerformanceEntryReporter`, thus generalizing what was earlier done in an ad-hoc way for marks and measures, and also allowing to have both observable/retrievable/buffered property for arbitrary performance entry type (with the ultimate goal of adding custom entry types, related to e.g. startup timing, something that we currently have an ad hoc API for). Differential Revision: D44574241 fbshipit-source-id: a48bf4d57bd08b34f33c2779d3bff80a96b824a1
rshest
force-pushed
the
export-D44574241
branch
from
ea539f7 to
50f85e8
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44574241 |
Base commit: 8b72c33 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44574241 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Mar 31, 2023
Summary: Pull Request resolved: facebook#36737 ## Changelog: [Internal] - Use `BoundedConsumableBuffer` in WebPerformance This makes use of the `BoundedConsumableBuffer` container type, introduced in D44544057, for buffering/observing arbitrary performance entry types in `WebPerformance/PerformanceEntryReporter`, thus generalizing what was earlier done in an ad-hoc way for marks and measures, and also allowing to have both observable/retrievable/buffered property for arbitrary performance entry type (with the ultimate goal of adding custom entry types, related to e.g. startup timing, something that we currently have an ad hoc API for). Differential Revision: D44574241 fbshipit-source-id: f987a3343501ed6ca069dbe2d494e6cc53fd5813
rshest
force-pushed
the
export-D44574241
branch
from
50f85e8 to
d5dfb3b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44574241 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Mar 31, 2023
Summary: Pull Request resolved: facebook#36737 ## Changelog: [Internal] - Use `BoundedConsumableBuffer` in WebPerformance This makes use of the `BoundedConsumableBuffer` container type, introduced in D44544057, for buffering/observing arbitrary performance entry types in `WebPerformance/PerformanceEntryReporter`, thus generalizing what was earlier done in an ad-hoc way for marks and measures, and also allowing to have both observable/retrievable/buffered property for arbitrary performance entry type (with the ultimate goal of adding custom entry types, related to e.g. startup timing, something that we currently have an ad hoc API for). Differential Revision: D44574241 fbshipit-source-id: 96b363f52f49245decd4fa67e8cc8488c89090ad
rshest
force-pushed
the
export-D44574241
branch
from
d5dfb3b to
83be7d9
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44574241 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Apr 3, 2023
Summary: Pull Request resolved: facebook#36737 ## Changelog: [Internal] - Use `BoundedConsumableBuffer` in WebPerformance This makes use of the `BoundedConsumableBuffer` container type, introduced in D44544057, for buffering/observing arbitrary performance entry types in `WebPerformance/PerformanceEntryReporter`, thus generalizing what was earlier done in an ad-hoc way for marks and measures, and also allowing to have both observable/retrievable/buffered property for arbitrary performance entry type (with the ultimate goal of adding custom entry types, related to e.g. startup timing, something that we currently have an ad hoc API for). Differential Revision: D44574241 fbshipit-source-id: 5a9ae54092f4852c22bc678decd36d61f2744428
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44574241 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Apr 3, 2023
Summary: Pull Request resolved: facebook#36737 ## Changelog: [Internal] - Use `BoundedConsumableBuffer` in WebPerformance This makes use of the `BoundedConsumableBuffer` container type, introduced in D44544057, for buffering/observing arbitrary performance entry types in `WebPerformance/PerformanceEntryReporter`, thus generalizing what was earlier done in an ad-hoc way for marks and measures, and also allowing to have both observable/retrievable/buffered property for arbitrary performance entry type (with the ultimate goal of adding custom entry types, related to e.g. startup timing, something that we currently have an ad hoc API for). Differential Revision: D44574241 fbshipit-source-id: c9fc75d29017eef33cfb549fd1a69b11b275c9b2
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44574241 |
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Apr 3, 2023
Summary: Pull Request resolved: facebook#36737 ## Changelog: [Internal] - Use `BoundedConsumableBuffer` in WebPerformance This makes use of the `BoundedConsumableBuffer` container type, introduced in D44544057, for buffering/observing arbitrary performance entry types in `WebPerformance/PerformanceEntryReporter`, thus generalizing what was earlier done in an ad-hoc way for marks and measures, and also allowing to have both observable/retrievable/buffered property for arbitrary performance entry type (with the ultimate goal of adding custom entry types, related to e.g. startup timing, something that we currently have an ad hoc API for). Differential Revision: D44574241 fbshipit-source-id: 7a610873017772a83172864c8ce2c50375184351
rshest
added a commit
to rshest/react-native
that referenced
this pull request
Apr 3, 2023
Summary: Pull Request resolved: facebook#36737 ## Changelog: [Internal] - Use `BoundedConsumableBuffer` in WebPerformance This makes use of the `BoundedConsumableBuffer` container type, introduced in D44544057, for buffering/observing arbitrary performance entry types in `WebPerformance/PerformanceEntryReporter`, thus generalizing what was earlier done in an ad-hoc way for marks and measures, and also allowing to have both observable/retrievable/buffered property for arbitrary performance entry type (with the ultimate goal of adding custom entry types, related to e.g. startup timing, something that we currently have an ad hoc API for). Differential Revision: D44574241 fbshipit-source-id: ad40cd0bc7ec8f599251c46ed9d9e1b540e5cd79
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44574241 |
…acebook#36726) Summary: Pull Request resolved: facebook#36726 ## Changelog: [Internal] - This implements (together with unit tests) a generic container type with the following properties: * It can only grow up to a specified max size * It's a circular buffer (the oldest elements are dropped if reached max size and adding a new element) * The entries can be "consumed" (once), which from the point of view of the consumer effectively clears the buffer * Even after the entries are consumed, all of the non-overwritten entries can still be independently retrieved an arbitrary amount of times The goal is to use it for buffering performance entries in the native WebPerformance implementation, where the model is that the performance entries should be both buffered/observable, but also for certain performance entry types (such as marks, measures and potentially certain event types) should be possible to retrieve all of them at any time (regardless of whether they have already been observed or not). In fact, this container is factoring that behavior, which is already there in `PerformanceEntryObserver` (but in an ad-hoc manner and only applicable to marks/measures), with the goal of being able to do it for any performance entry type. Differential Revision: https://internalfb.com/D44544057 fbshipit-source-id: 913b10ec996e8ddf707c87a3fbb97345219c4271
Summary: Pull Request resolved: facebook#36737 ## Changelog: [Internal] - Use `BoundedConsumableBuffer` in WebPerformance This makes use of the `BoundedConsumableBuffer` container type, introduced in D44544057, for buffering/observing arbitrary performance entry types in `WebPerformance/PerformanceEntryReporter`, thus generalizing what was earlier done in an ad-hoc way for marks and measures, and also allowing to have both observable/retrievable/buffered property for arbitrary performance entry type (with the ultimate goal of adding custom entry types, related to e.g. startup timing, something that we currently have an ad hoc API for). Reviewed By: sammy-SC Differential Revision: D44574241 fbshipit-source-id: 9e7ca28227982d3440bce6eaaa6394a2788cc442
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D44574241 |
Contributor
|
This pull request has been merged in 9504720. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
Summary: Pull Request resolved: facebook#36737 ## Changelog: [Internal] - Use `BoundedConsumableBuffer` in WebPerformance This makes use of the `BoundedConsumableBuffer` container type, introduced in D44544057, for buffering/observing arbitrary performance entry types in `WebPerformance/PerformanceEntryReporter`, thus generalizing what was earlier done in an ad-hoc way for marks and measures, and also allowing to have both observable/retrievable/buffered property for arbitrary performance entry type (with the ultimate goal of adding custom entry types, related to e.g. startup timing, something that we currently have an ad hoc API for). Reviewed By: sammy-SC Differential Revision: D44574241 fbshipit-source-id: a858712ff1cf468914a80c99f6b82d060cb0b702
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#36737 ## Changelog: [Internal] - Use `BoundedConsumableBuffer` in WebPerformance This makes use of the `BoundedConsumableBuffer` container type, introduced in D44544057, for buffering/observing arbitrary performance entry types in `WebPerformance/PerformanceEntryReporter`, thus generalizing what was earlier done in an ad-hoc way for marks and measures, and also allowing to have both observable/retrievable/buffered property for arbitrary performance entry type (with the ultimate goal of adding custom entry types, related to e.g. startup timing, something that we currently have an ad hoc API for). Reviewed By: sammy-SC Differential Revision: D44574241 fbshipit-source-id: a858712ff1cf468914a80c99f6b82d060cb0b702
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[Internal] - Use
BoundedConsumableBufferin WebPerformanceThis makes use of the
BoundedConsumableBuffercontainer type, introduced in D44544057, for buffering/observing arbitrary performance entry types inWebPerformance/PerformanceEntryReporter, thus generalizing what was earlier done in an ad-hoc way for marks and measures, and also allowing to have both observable/retrievable/buffered property for arbitrary performance entry type (with the ultimate goal of adding custom entry types, related to e.g. startup timing, something that we currently have an ad hoc API for).Differential Revision: D44574241