Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ import {
} from '../parsers-commons';
import type {ParserType} from '../errors';

const {Visitor} = require('../flow/Visitor');
const {Visitor} = require('../parsers-primitives');
const {wrapComponentSchema} = require('../schema.js');
const {buildComponentSchema} = require('../flow/components');
const {buildModuleSchema} = require('../parsers-commons.js');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const {
emitMixed,
typeAliasResolution,
typeEnumResolution,
Visitor,
} = require('../parsers-primitives.js');
const {MockedParser} = require('../parserMock');
const {emitUnion} = require('../parsers-primitives');
Expand Down Expand Up @@ -1155,3 +1156,102 @@ describe('emitArrayType', () => {
});
});
});

describe('Visitor', () => {
describe('CallExpression', () => {
it('sets isComponent to true if callee type is Identifier and callee name is codegenNativeComponent', () => {
const infoMap = {isComponent: false, isModule: false};
const node = {
callee: {type: 'Identifier', name: 'codegenNativeComponent'},
};
const visitor = Visitor(infoMap);
visitor.CallExpression(node);

expect(infoMap.isComponent).toBe(true);
});

it('should not set isComponent to true if callee type is not Identifier or callee name is not codegenNativeComponent', () => {
const infoMap = {isComponent: false, isModule: false};
const node = {
callee: {type: '', name: ''},
};
const visitor = Visitor(infoMap);
visitor.CallExpression(node);

expect(infoMap.isComponent).toBe(false);
});

it('sets isModule to true if isModuleRegistryCall', () => {
const infoMap = {isComponent: false, isModule: false};
const node = {
type: 'CallExpression',
callee: {
type: 'MemberExpression',
object: {type: 'Identifier', name: 'TurboModuleRegistry'},
property: {type: 'Identifier', name: 'getEnforcing'},
},
};
const visitor = Visitor(infoMap);
visitor.CallExpression(node);

expect(infoMap.isModule).toBe(true);
});

it('should not set isModule to true if not isModuleRegistryCall', () => {
const infoMap = {isComponent: false, isModule: false};
const node = {
callee: {
type: 'Expression',
},
};
const visitor = Visitor(infoMap);
visitor.CallExpression(node);

expect(infoMap.isModule).toBe(false);
});
});

describe('InterfaceExtends', () => {
it('sets isModule to true if module interface extends TurboModule', () => {
const infoMap = {isComponent: false, isModule: false};
const node = {id: {name: 'TurboModule'}};

const visitor = Visitor(infoMap);
visitor.InterfaceExtends(node);

expect(infoMap.isModule).toBe(true);
});

it('should not set isModule to true if module interface does not extends TurboModule', () => {
const infoMap = {isComponent: false, isModule: false};
const node = {id: {name: ''}};

const visitor = Visitor(infoMap);
visitor.InterfaceExtends(node);

expect(infoMap.isModule).toBe(false);
});
});

describe('TSInterfaceDeclaration', () => {
it('sets isModule to true if TypeScript Interface Declaration extends TurboModule', () => {
const infoMap = {isComponent: false, isModule: false};
const node = {extends: [{expression: {name: 'TurboModule'}}]};

const visitor = Visitor(infoMap);
visitor.TSInterfaceDeclaration(node);

expect(infoMap.isModule).toBe(true);
});

it('should not set isModule to true if TypeScript Interface Declaration does not extends TurboModule', () => {
const infoMap = {isComponent: false, isModule: false};
const node = {extends: [{expression: {name: ''}}]};

const visitor = Visitor(infoMap);
visitor.TSInterfaceDeclaration(node);

expect(infoMap.isModule).toBe(false);
});
});
});
41 changes: 0 additions & 41 deletions packages/react-native-codegen/src/parsers/flow/Visitor.js

This file was deleted.

2 changes: 1 addition & 1 deletion packages/react-native-codegen/src/parsers/flow/parser.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const {flowTranslateTypeAnnotation} = require('./modules');
const flowParser = require('flow-parser');

const {buildSchema} = require('../parsers-commons');
const {Visitor} = require('./Visitor');
const {Visitor} = require('../parsers-primitives');
const {buildComponentSchema} = require('./components');
const {wrapComponentSchema} = require('../schema.js');
const {buildModuleSchema} = require('../parsers-commons.js');
Expand Down
37 changes: 37 additions & 0 deletions packages/react-native-codegen/src/parsers/parsers-primitives.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,8 @@ const {
translateFunctionTypeAnnotation,
} = require('./parsers-commons');

const {isModuleRegistryCall} = require('./utils');

function emitBoolean(nullable: boolean): Nullable<BooleanTypeAnnotation> {
return wrapNullable(nullable, {
type: 'BooleanTypeAnnotation',
Expand Down Expand Up @@ -439,6 +441,40 @@ function emitArrayType(
);
}

function Visitor(infoMap: {isComponent: boolean, isModule: boolean}): {
[type: string]: (node: $FlowFixMe) => void,
} {
return {
CallExpression(node: $FlowFixMe) {
if (
node.callee.type === 'Identifier' &&
node.callee.name === 'codegenNativeComponent'
) {
infoMap.isComponent = true;
}

if (isModuleRegistryCall(node)) {
infoMap.isModule = true;
}
},
InterfaceExtends(node: $FlowFixMe) {
if (node.id.name === 'TurboModule') {
infoMap.isModule = true;
}
},
TSInterfaceDeclaration(node: $FlowFixMe) {
if (
Array.isArray(node.extends) &&
node.extends.some(
extension => extension.expression.name === 'TurboModule',
)
) {
infoMap.isModule = true;
}
},
};
}

module.exports = {
emitArrayType,
emitBoolean,
Expand All @@ -459,4 +495,5 @@ module.exports = {
typeAliasResolution,
typeEnumResolution,
translateArrayTypeAnnotation,
Visitor,
};
47 changes: 0 additions & 47 deletions packages/react-native-codegen/src/parsers/typescript/Visitor.js

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const {typeScriptTranslateTypeAnnotation} = require('./modules');
const babelParser = require('@babel/parser');

const {buildSchema} = require('../parsers-commons');
const {Visitor} = require('./Visitor');
const {Visitor} = require('../parsers-primitives');
const {buildComponentSchema} = require('./components');
const {wrapComponentSchema} = require('../schema.js');
const {buildModuleSchema} = require('../parsers-commons.js');
Expand Down