chore: Remove ruby-version from 0.71 #36423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
kelset
approved these changes
Mar 9, 2023
High5Apps
added a commit
to High5Apps/organize-rn
that referenced
this pull request
Apr 19, 2023
- Upgrade RN dependencies and fix node type issue - Upgrade react-navigation to fix failing tests - react-navigation/react-navigation#9183 - Updated pods - Used upgrade helper to update pbxproj file - https://react-native-community.github.io/upgrade-helper/?from=0.67.3&to=0.71.6#RnDiffApp-ios-RnDiffApp.xcodeproj-project.pbxproj - Upgrade react-native-vector-icons from 9.1.0 to 9.2.0 - Fix warning oblador/react-native-vector-icons#1443 (comment) - Fix iOS configuration deprecated warning ``` warn --configuration has been deprecated. Use --mode instead. warn Parameters were automatically reassigned to --mode on this run. ``` - Fix iOS multiple Podfiles warning - https://stackoverflow.com/a/74341089/2421313 ``` warn Multiple Podfiles were found: ios/Podfile,vendor/bundle/ruby/2.7.0/gems/cocoapods-core-1.11.2/lib/cocoapods-core/Podfile. Choosing ios/Podfile automatically. If you would like to select a different one, you can configure it via "project.ios.sourceDir". You can learn more about it here: https://github.com/react-native-community/cli/blob/master/docs/configuration.md ``` - Remove .ruby-version - Recommended by the upgrade helper - facebook/react-native#36423
|
We should update the documentation as well |
kraenhansen
added a commit
to realm/realm-js
that referenced
this pull request
May 11, 2023
Due to facebook/react-native#36423 we need specify a Ruby version.
kraenhansen
added a commit
to realm/realm-js
that referenced
this pull request
May 12, 2023
Due to facebook/react-native#36423 we need specify a Ruby version.
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Starting from 0.72, we won't be pin any specific ruby version. However, 0.70 and 0.71 are still doing that.
This PR against 0.71, removes the pinning of a specific version of Ruby
Changelog
[iOS][Changed] - Do not pin a specific version of Ruby.
Test Plan