Skip to content

[Codegen 99] Extract throwIfMoreThanOneCodegenNativecommands error in error-utils #36407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tarunrajput wants to merge 1 commit into from
Closed

[Codegen 99] Extract throwIfMoreThanOneCodegenNativecommands error in error-utils #36407

tarunrajput wants to merge 1 commit into from

Conversation

@tarunrajput
Copy link
Contributor

@tarunrajput tarunrajput commented Mar 8, 2023

Summary

Part of Codegen Umbrella Issue: #34872

[Codegen 99] Extract the throwIfMoreThanOneCodegenNativecommands error in the error-utils.js file and extract the error code from Flow and TS

Changelog

[Internal] [Changed] - Extract throwIfMoreThanOneCodegenNativecommands error in error-utils

Test Plan

yarn jest react-native-codegen

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 8, 2023
cipolleschi
cipolleschi approved these changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@cipolleschi cipolleschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, as usual! 👏

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 8, 2023

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@analysis-bot
Copy link

analysis-bot commented Mar 8, 2023 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,517,289 +0
android hermes armeabi-v7a 7,833,334 +0
android hermes x86 8,997,657 +0
android hermes x86_64 8,852,646 +0
android jsc arm64-v8a 9,141,130 +0
android jsc armeabi-v7a 8,333,010 +0
android jsc x86 9,195,927 +0
android jsc x86_64 9,453,756 +0

Base commit: 57a2508
Branch: main

@cipolleschi
Copy link
Contributor

cipolleschi commented Mar 9, 2023

/rebase

@github-actions github-actions bot force-pushed the refactor/extarct-throwIfMoreThanOneCodegenNativecommands branch from 0327ba9 to 0028bf2 Compare March 9, 2023 09:45
@cipolleschi
Copy link
Contributor

cipolleschi commented Mar 9, 2023 •
edited
Loading

I don't understand why CircleCI on main is passing, but it is not passing in this PR. :/
There are no Ruby-related differences...

@tarunrajput
Copy link
Contributor Author

tarunrajput commented Mar 9, 2023

I don't understand why CircleCI on main is passing, but it is not passing in this PR. :/ There are no Ruby-related differences...

I see that these tests are failing in my other PR's too :(. But there are no ruby related changes

@tarunrajput
Copy link
Contributor Author

tarunrajput commented Mar 9, 2023

/rebase

@github-actions github-actions bot force-pushed the refactor/extarct-throwIfMoreThanOneCodegenNativecommands branch from 0028bf2 to 8361db0 Compare March 9, 2023 18:28
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 10, 2023

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Contributor

cipolleschi commented Mar 13, 2023

/rebase

@github-actions github-actions bot force-pushed the refactor/extarct-throwIfMoreThanOneCodegenNativecommands branch from 8361db0 to cbecfe6 Compare March 13, 2023 09:31
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 13, 2023

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cipolleschi
Copy link
Contributor

cipolleschi commented Mar 13, 2023

/rebase

@github-actions github-actions bot force-pushed the refactor/extarct-throwIfMoreThanOneCodegenNativecommands branch from cbecfe6 to 2331ff6 Compare March 13, 2023 14:13
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 13, 2023

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@tarunrajput tarunrajput force-pushed the refactor/extarct-throwIfMoreThanOneCodegenNativecommands branch from 2331ff6 to 9a806d2 Compare March 14, 2023 18:54
@tarunrajput
Copy link
Contributor Author

tarunrajput commented Mar 15, 2023

/rebase

@github-actions github-actions bot force-pushed the refactor/extarct-throwIfMoreThanOneCodegenNativecommands branch from 9a806d2 to e24fd99 Compare March 15, 2023 06:10
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 15, 2023

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Mar 15, 2023
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 15, 2023

@cipolleschi merged this pull request in 347d6f8.

OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
@tarunrajput @OlimpiaZurek
Extract throwIfMoreThanOneCodegenNativecommands error in error-utils (f…
51d9542 
…acebook#36407)

Summary:
Part of Codegen Umbrella Issue: facebook#34872
> [Codegen 99] Extract the throwIfMoreThanOneCodegenNativecommands error in the error-utils.js file and extract the error code from [Flow](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/flow/components/index.js#L111-L133) and [TS](https://github.com/facebook/react-native/blob/main/packages/react-native-codegen/src/parsers/typescript/components/index.js#L112-L114)

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry.

Pick one each for the category and type tags:

[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message

For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[Internal] [Changed] - Extract throwIfMoreThanOneCodegenNativecommands error in error-utils

Pull Request resolved: facebook#36407

Test Plan: `yarn jest react-native-codegen`

Reviewed By: christophpurrer

Differential Revision: D43912403

Pulled By: cipolleschi

fbshipit-source-id: 1c51fc01465a1baa5f06ccea09c3342584bb82cc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cipolleschi cipolleschi cipolleschi approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tarunrajput @facebook-github-bot @analysis-bot @cipolleschi