Properly support both libraries and use_frameworks (#35624) #35637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 9f9111b |
Contributor
|
@cipolleschi merged this pull request in be895c8. |
cipolleschi
deleted the
backport/properly_support_both_libraries_and_use_frameworks
branch
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…acebook#35637) Summary: Backporting a [fix](facebook@c6fa633) on the `ReactCommon.podspec` to properly support static libraries and static frameworks ## Changelog [IOS][FIXED] - Properly support static libraries and static frameworks Pull Request resolved: facebook#35637 Test Plan: Tested in 0.71-RC4 Reviewed By: christophpurrer Differential Revision: D42029571 Pulled By: cipolleschi fbshipit-source-id: e562fe211931a0aebba282057589e5dd4fafe3ba
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backporting a fix on the
ReactCommon.podspecto properly support static libraries andstatic frameworks
Changelog
[IOS][FIXED] - Properly support static libraries and static frameworks
Test Plan
Tested in 0.71-RC4