Expose hermes-executor to be consumed via prefab
#35457
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41520019 |
Base commit: 9517320 |
Base commit: 9517320 |
|
PR build artifact for 7bd618f is ready. |
Summary: Historically, we used to have hermes-executor debug and release as separate dynamic libraries. This makes it impossible to prefab this library, so I have to reconcile it into a single library. This will also help keep the setup consistent with the internal (BUCK) where we have a single target. Changelog: [Internal] [Changed] - Consolidate hermes-executor-debug and -release inside a single target Differential Revision: D41519119 fbshipit-source-id: aaecbef87e99efff6048f8b9c5ceb4c6f24f621b
Summary: Pull Request resolved: facebook#35457 This exposes `hermes-executor` to be consumed via prefab so that libraries can depend on it and use its symbols if needed (Expo and Reanimated need it). Changelog: [Internal] [Changed] - Expose `hermes-executor` to be consumed via prefab Differential Revision: D41520019 fbshipit-source-id: 0fa6564b7f6fe8e01f202e8c161929df86351506
|
PR build artifact for 7bd618f is ready. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41520019 |
cortinico
force-pushed
the
export-D41520019
branch
from
7bd618f to
0d04a4a
Compare
|
PR build artifact for 0d04a4a is ready. |
|
PR build artifact for 0d04a4a is ready. |
tomekzaw
reviewed
Nov 24, 2022
| // This prefab target is used by Expo & Reanimated to load a new instance of Hermes | ||
| new PrefabPreprocessingEntry( | ||
| "hermes-executor", | ||
| // "hermes-executor" is statically linking agaisnt "hermes-executor-common" |
Contributor
There was a problem hiding this comment.
Suggested change
| // "hermes-executor" is statically linking agaisnt "hermes-executor-common" | |
| // "hermes-executor" is statically linking against "hermes-executor-common" |
Collaborator
|
This pull request was successfully merged by @cortinico in b70707b. When will my fix make it into a release? | Upcoming Releases |
cortinico
added a commit
that referenced
this pull request
Nov 29, 2022
Summary: Pull Request resolved: #35457 This exposes `hermes-executor` to be consumed via prefab so that libraries can depend on it and use its symbols if needed (Expo and Reanimated need it). Changelog: [Internal] [Changed] - Expose `hermes-executor` to be consumed via prefab Reviewed By: cipolleschi Differential Revision: D41520019 fbshipit-source-id: d590a043ea89fdd8ff41b0ed20900c9cf381a1e4
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#35457 This exposes `hermes-executor` to be consumed via prefab so that libraries can depend on it and use its symbols if needed (Expo and Reanimated need it). Changelog: [Internal] [Changed] - Expose `hermes-executor` to be consumed via prefab Reviewed By: cipolleschi Differential Revision: D41520019 fbshipit-source-id: d590a043ea89fdd8ff41b0ed20900c9cf381a1e4
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This exposes
hermes-executorto be consumed via prefab so thatlibraries can depend on it and use its symbols if needed (Expo and Reanimated need it).
Changelog:
[Internal] [Changed] - Expose
hermes-executorto be consumed via prefabDifferential Revision: D41520019