fix: Change checkout cache strategy

[cipolleschi]

Summary

This PR updates he cache strategy for the checkout_with_cache command.

The previous strategy was using three keys in descending priority order to restore from the cache:

• << parameters.checkout_base_cache_key >>-{{ arch }}-{{ .Branch }}-{{ .Revision }}
• << parameters.checkout_base_cache_key >>-{{ arch }}-{{ .Branch }}
  *<< parameters.checkout_base_cache_key >>-{{ arch }}

When it saves, it always saves using the first key.

The restore works as it follows:

1. It tries to restore the cache using the first key
2. If it fails, it checks whether there is a cache hit for a key that matches the second key as a pattern
3. If it fails, it checks whether there is a cache hit for a key that matches the third pattern
4. Otherwise, it is a cache miss.

This does not work well. Imagine that you submit some code in commit xxxx for branch abc.
The CI run the first time, it misses all the three keys and checks out the code normally.
Then, it stores the checked out code in the checkout_key-abc-xxxx key.

Then, you submit a commit yyyy in the same branch.
The CI starts, it tries with the key checkout_key-abc-yyyy but it misses
It tries with the key checkout_key-abc and it finds the cache for checkout_key-abc-xxxx and it restores it, forgetting about your changes.

While doing the release, we created a tag in a commit X. Then we manually had to remove it, but the CI had a cached version of .git with the tag for
the 0.71-stable branch. And the release failed because the tag was already existing.

Why this should work

With this solution, we are going to cache using the commit. If there is no cache for a specific commit, it will be a miss. It won't try to be smart and
retrieve the code from previous caches.

This should prevent stale caches and if we manually remove a tag, and then we do a new commit, it should work.

This is a good trade-off that allows to pay the checkout cost only for the first batch of jobs of the pipeline.

NOTE: This still won't work if we don't do a new commit.

Changelog

[General] [Fixed] - Change Cache strategy to avoid cache bumps in Release

Test Plan

1. CircleCI must be green

[facebook-github-bot]

@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
ios	-	universal	n/a	--

Base commit: dac6806
Branch: main

[analysis-bot]

Platform	Engine	Arch	Size (bytes)	Diff
android	hermes	arm64-v8a	7,068,113	+0
android	hermes	armeabi-v7a	6,440,497	+0
android	hermes	x86	7,483,431	+0
android	hermes	x86_64	7,342,828	+0
android	jsc	arm64-v8a	8,933,067	+0
android	jsc	armeabi-v7a	7,667,418	+0
android	jsc	x86	8,993,443	+0
android	jsc	x86_64	9,472,201	+0

Base commit: dac6806
Branch: main

[react-native-bot]

This pull request was successfully merged by @cipolleschi in ddba780.

^{When will my fix make it into a release? | Upcoming Releases}