Remove project.android block from rn-tester's CLI config #35197
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 8183aac |
Collaborator
|
This pull request was successfully merged by @cortinico in ef75de9. When will my fix make it into a release? | Upcoming Releases |
cipolleschi
pushed a commit
that referenced
this pull request
Nov 4, 2022
Summary: The project.android block is unnecessary and contains a wrong path. Let's use the default path which is `./android`. ## Changelog [Internal] - Remove project.android block from rn-tester's CLI config Pull Request resolved: #35197 Test Plan: Tested locally + will wait for a CI run Reviewed By: robhogan Differential Revision: D41013193 Pulled By: cortinico fbshipit-source-id: 5c76c9b571b23ad71a23a8f3f05a9acb4d6e20b9
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
) Summary: The project.android block is unnecessary and contains a wrong path. Let's use the default path which is `./android`. ## Changelog [Internal] - Remove project.android block from rn-tester's CLI config Pull Request resolved: facebook#35197 Test Plan: Tested locally + will wait for a CI run Reviewed By: robhogan Differential Revision: D41013193 Pulled By: cortinico fbshipit-source-id: 5c76c9b571b23ad71a23a8f3f05a9acb4d6e20b9
Merged
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The project.android block is unnecessary and contains a wrong path. Let's use the default path which is
./android.Changelog
[Internal] - Remove project.android block from rn-tester's CLI config
Test Plan
Tested locally + will wait for a CI run