chore: Export codegen parseFile function #35000
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: f6cfcc3 |
Base commit: f6cfcc3 |
cipolleschi
approved these changes
Oct 17, 2022
Contributor
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thanks for doing this. It looks good to me! :D
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
gabrieldonadel
force-pushed
the
chore/export-parse-file
branch
from
b707842 to
b2a1e52
Compare
Contributor
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
Author
|
@cipolleschi would you mind checking what the Facebook Internal Linter is complaining about for me? |
gabrieldonadel
force-pushed
the
chore/export-parse-file
branch
from
b2a1e52 to
8db3d79
Compare
gabrieldonadel
force-pushed
the
chore/export-parse-file
branch
from
8db3d79 to
bf97fd8
Compare
cortinico
approved these changes
Oct 18, 2022
Collaborator
|
This pull request was successfully merged by @gabrieldonadel in 376ffac. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: This PR export the content of the `parseFile` into a parseFile function accepting a callback to buildSchema properly in `parsers/utils.js` as requested on facebook#34872. ## Changelog [Internal] [Changed] - Export ` parseFile` in to a `parseFile` function in `parsers/utils.js` Pull Request resolved: facebook#35000 Test Plan: Run `yarn jest react-native-codegen` and ensure CI is green  Reviewed By: cortinico Differential Revision: D40424857 Pulled By: cipolleschi fbshipit-source-id: a700033d674b8be8e1af942dedf73155ea3ca025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR export the content of the
parseFileinto a parseFile function accepting a callback to buildSchema properly inparsers/utils.jsas requested on #34872.Changelog
[Internal] [Changed] - Export
parseFilein to aparseFilefunction inparsers/utils.jsTest Plan
Run
yarn jest react-native-codegenand ensure CI is green