[Codegen] Extract visit function to parsers/utils #34946
Conversation
facebook-github-bot
added
the
CLA Signed
| return [errors, guard]; | ||
| } | ||
|
|
||
| // TODO(T108222691): Use flow-types for @babel/parser |
There was a problem hiding this comment.
There was a different TODO comment in Flow and Typescript folders, I pasted one of them
| }); | ||
| }); | ||
|
|
||
| describe('visit', () => { |
There was a problem hiding this comment.
I tried to test each branch, jest gives me 100% coverage but please tell me if you see a way to improve these tests.
There was a problem hiding this comment.
They looks good to me!
Base commit: 5d8a712 |
Base commit: 5d8a712 |
cipolleschi
left a comment
cipolleschi
left a comment
There was a problem hiding this comment.
Thank you so much for the effort! It is amazing that we are also testing all this code! 🤩
| }); | ||
| }); | ||
|
|
||
| describe('visit', () => { |
There was a problem hiding this comment.
They looks good to me!
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
AntoineDoubovetzky
force-pushed
the
refactor/extract-visit-function
branch
from
f57219c to
95ec098
Compare
|
I rebased the branch because of conflicts |
|
@cipolleschi Do you need me to update something on this PR or is everything ok ? |
|
Thank you! No, nothing else from your side. I'll try to land this between today and tomorrow! 👍 |
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
This pull request was successfully merged by @AntoineDoubovetzky in 3c8d678. When will my fix make it into a release? | Upcoming Releases |
Summary: This PR is a task from facebook#34872: > Extract the visit function in a shared function in the parsers/utils.js folder. Use the new function in the Flow and TypeScript parsers. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Extract the visit function in a shared function in the parsers/utils.js Pull Request resolved: facebook#34946 Test Plan: I tested using jest, flow and eslint commands. Reviewed By: NickGerleman Differential Revision: D40276462 Pulled By: cipolleschi fbshipit-source-id: 299cc2a3aa65a9757b217192a13838d037c497a1
5 participants
Summary
This PR is a task from #34872:
Changelog
[Internal] [Changed] - Extract the visit function in a shared function in the parsers/utils.js
Test Plan
I tested using jest, flow and eslint commands.