chore: Extract codegen case 'Stringish' into a single emitStringish function #34936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Base commit: f353119 |
Base commit: f353119 |
Contributor
|
@rshest has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
rshest
approved these changes
Oct 11, 2022
gabrieldonadel
force-pushed
the
chore/extract-stringish-int-emit-stringish
branch
from
1cfddec to
b418b3a
Compare
Collaborator
|
This pull request was successfully merged by @gabrieldonadel in 305f7c3. When will my fix make it into a release? | Upcoming Releases |
mohitcharkha
pushed a commit
to mohitcharkha/react-native
that referenced
this pull request
Oct 17, 2022
…unction (facebook#34936) Summary: This PR extracts the content of the codegen case `'Stringish'` into a single `emitStringish` function inside the `parsers-primitives.js` file and uses it in both Flow and TypeScript parsers as requested on facebook#34872. This also adds unit tests to the new `emitStringish` function. ## Changelog [Internal] [Changed] - Extract the content of the case 'Stringish' into a single emitStringish function Pull Request resolved: facebook#34936 Test Plan: Run `yarn jest react-native-codegen` and ensure CI is green  Reviewed By: cipolleschi Differential Revision: D40255921 Pulled By: rshest fbshipit-source-id: 9c08f81f12c93995bb6ba032fabcd6451b8dc7c1
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 19, 2022
#34981) Summary: This PR extracts the content of the codegen case 'String' into a single `emitString` function inside the parsers-primitives.js file and uses it in both Flow and TypeScript parsers as requested on #34872. This also adds unit tests to the new `emitString` function. ref: #34936 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Extract the content of the case 'StringTypeAnnotation' into a single emitString function Pull Request resolved: #34981 Test Plan: Run `yarn jest react-native-codegen` and ensure CI is green Reviewed By: cortinico Differential Revision: D40376836 Pulled By: cipolleschi fbshipit-source-id: feb1b07ec7fc2c333f5054f8cd8d18457d985257
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…unction (facebook#34936) Summary: This PR extracts the content of the codegen case `'Stringish'` into a single `emitStringish` function inside the `parsers-primitives.js` file and uses it in both Flow and TypeScript parsers as requested on facebook#34872. This also adds unit tests to the new `emitStringish` function. ## Changelog [Internal] [Changed] - Extract the content of the case 'Stringish' into a single emitStringish function Pull Request resolved: facebook#34936 Test Plan: Run `yarn jest react-native-codegen` and ensure CI is green  Reviewed By: cipolleschi Differential Revision: D40255921 Pulled By: rshest fbshipit-source-id: 9c08f81f12c93995bb6ba032fabcd6451b8dc7c1
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
facebook#34981) Summary: This PR extracts the content of the codegen case 'String' into a single `emitString` function inside the parsers-primitives.js file and uses it in both Flow and TypeScript parsers as requested on facebook#34872. This also adds unit tests to the new `emitString` function. ref: facebook#34936 ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Changed] - Extract the content of the case 'StringTypeAnnotation' into a single emitString function Pull Request resolved: facebook#34981 Test Plan: Run `yarn jest react-native-codegen` and ensure CI is green Reviewed By: cortinico Differential Revision: D40376836 Pulled By: cipolleschi fbshipit-source-id: feb1b07ec7fc2c333f5054f8cd8d18457d985257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR extracts the content of the codegen case
'Stringish'into a singleemitStringishfunction inside theparsers-primitives.jsfile and uses it in both Flow and TypeScript parsers as requested on #34872. This also adds unit tests to the newemitStringishfunction.Changelog
[Internal] [Changed] - Extract the content of the case 'Stringish' into a single emitStringish function
Test Plan
Run
yarn jest react-native-codegenand ensure CI is green