Simplify the dependencies migration for new libraries #34619
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39312203 |
Base commit: 47a05bc |
Summary: Pull Request resolved: facebook#34619 When it comes to migrate existing libraries, users needs to update their .podspec files with a bunch [of changes](https://reactnative.dev/docs/0.69/new-architecture-library-ios#add-folly-and-other-dependencies). This diff groups those changes in a single function, so that contributors can just invoke that function to prepare their dependencies. ## Changelog [iOS][Changed] - Add function to simplify podspecs Differential Revision: D39312203 fbshipit-source-id: c000b9b05187fbf49f65bb5d948880d96361a633
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D39312203 |
cipolleschi
force-pushed
the
export-D39312203
branch
from
f8f11fc to
2ef8f25
Compare
Collaborator
|
This pull request was successfully merged by @cipolleschi in 82e9c6a. When will my fix make it into a release? | Upcoming Releases |
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Pull Request resolved: facebook#34619 When it comes to migrate existing libraries, users needs to update their .podspec files with a bunch [of changes](https://reactnative.dev/docs/0.69/new-architecture-library-ios#add-folly-and-other-dependencies). This diff groups those changes in a single function, so that contributors can just invoke that function to prepare their dependencies. ## Changelog [iOS][Changed] - Add function to simplify podspecs Reviewed By: cortinico Differential Revision: D39312203 fbshipit-source-id: ed631839e07d472a1fdcba33310f9b1d94fe2fd7
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
When it comes to migrate existing libraries, users needs to update their .podspec files with a bunch of changes.
This diff groups those changes in a single function, so that contributors can just invoke that function to prepare their dependencies.
Changelog:
[iOS][Changed] Add function to simplify podspecs
Differential Revision: D39312203