-
Notifications
You must be signed in to change notification settings - Fork 25k
feat: added accessibility value aliases #34535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
dakshbhardwaj
wants to merge
15
commits into
facebook:main
from
dakshbhardwaj:daksh/add-accessibility-value
Closed
Changes from 11 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
28266c4
feat: added accessibility value alias
e57536f
docs changes
ec39394
updated the snapshots for failing testcases
78a5094
Merge branch 'facebook:main' into daksh/add-accessibility-value
9560307
Merge branch 'facebook:main' into daksh/add-accessibility-value
b284db5
Merge branch 'facebook:main' into daksh/add-accessibility-value
56bd3cf
Merge branch 'main' into daksh/add-accessibility-value
46c70d8
Merge branch 'main' into daksh/add-accessibility-value
cb105cb
Merge branch 'main' into daksh/add-accessibility-value
93053fd
Merge branch 'main' into daksh/add-accessibility-value
6c7fb7e
pr review changes
410727e
Update Libraries/Components/Pressable/Pressable.js
41d2125
Merge branch 'main' into daksh/add-accessibility-value
7fbb627
removed linting issue
cdbc72f
added nullish coalescing operaor
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -50,6 +50,10 @@ type Props = $ReadOnly<{| | |||||
| accessibilityRole?: ?AccessibilityRole, | ||||||
| accessibilityState?: ?AccessibilityState, | ||||||
| accessibilityValue?: ?AccessibilityValue, | ||||||
| 'aria-valuemax'?: AccessibilityValue['max'], | ||||||
| 'aria-valuemin'?: AccessibilityValue['min'], | ||||||
| 'aria-valuenow'?: AccessibilityValue['now'], | ||||||
| 'aria-valuetext'?: AccessibilityValue['text'], | ||||||
| accessibilityViewIsModal?: ?boolean, | ||||||
| accessible?: ?boolean, | ||||||
|
|
||||||
|
|
@@ -238,12 +242,32 @@ function Pressable(props: Props, forwardedRef): React.Node { | |||||
| _accessibilityState = | ||||||
| disabled != null ? {..._accessibilityState, disabled} : _accessibilityState; | ||||||
|
|
||||||
| const accessibilityValue = { | ||||||
| max: | ||||||
| props['aria-valuemax'] !== null | ||||||
| ? props['aria-valuemax'] | ||||||
| : props.accessibilityValue?.max, | ||||||
| min: | ||||||
| props['aria-valuemin'] !== null | ||||||
| ? props['aria-valuemin'] | ||||||
| : props.accessibilityValue?.min, | ||||||
| now: | ||||||
| props['aria-valuenow'] !== null | ||||||
| ? props['aria-valuenow'] | ||||||
| : props.accessibilityValue?.now, | ||||||
| text: | ||||||
| props['aria-valuetext'] !== null | ||||||
| ? props['aria-valuetext'] | ||||||
| : props.accessibilityValue?.max, | ||||||
|
||||||
| : props.accessibilityValue?.max, | |
| : props.accessibilityValue?.text, |
dakshbhardwaj marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
dakshbhardwaj marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more accurate and simple, please update the change for rest of properties on all changed files.