Added files for node version in reactive native project #34171
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Changelog: [General][Added] - Added files for `avn`, `nodenv`, and other managers that set the node.js version in reactive native project including testing Reviewed By: cortinico Differential Revision: D37683291 fbshipit-source-id: 5ea1eed66ca949b1074e3ab7d3599cad81993218
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37683291 |
react-native-bot
added
the
Type: Enhancement
Base commit: b834d58 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37683291 |
4 similar comments
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37683291 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37683291 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37683291 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D37683291 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 11, 2022
Summary: Pull Request resolved: #34171 Changelog: [General][Added] - Added files for `avn`, `nodenv`, and other managers that set the node.js version in reactive native project including testing Reviewed By: cortinico Differential Revision: D37683291 fbshipit-source-id: ef0df0fb07f5cc0fa3591dde487f65e4b1b5f73f
Collaborator
|
This pull request was successfully merged by @ramonmedel in 933fbb1. When will my fix make it into a release? | Upcoming Releases |
Contributor
|
i guess if we are currently using a |
Author
exactly |
|
How do we know if we need to add this file? |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 25, 2022
Summary: Node 18: https://nodejs.org/de/blog/announcements/v18-release-announce/ Node 16 EOL: 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ Node 18 EOL: 2025-04-30 Follow-up - #34171 - #32980 Ref - react-native-community/docker-android#187 cc ramonmedel cortinico gengjiawen ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [JavaScript] [Changed] - Bump node version from 16 to 18 Pull Request resolved: #35443 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D41531161 Pulled By: cortinico fbshipit-source-id: 305888f55ed179f75bef34548aebf22fc2951308
hoxyq
pushed a commit
to hoxyq/react-native
that referenced
this pull request
Jan 25, 2023
Summary: Node 18: https://nodejs.org/de/blog/announcements/v18-release-announce/ Node 16 EOL: 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ Node 18 EOL: 2025-04-30 Follow-up - facebook#34171 - facebook#32980 Ref - react-native-community/docker-android#187 cc ramonmedel cortinico gengjiawen ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [JavaScript] [Changed] - Bump node version from 16 to 18 Pull Request resolved: facebook#35443 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D41531161 Pulled By: cortinico fbshipit-source-id: 305888f55ed179f75bef34548aebf22fc2951308
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
Summary: Node 18: https://nodejs.org/de/blog/announcements/v18-release-announce/ Node 16 EOL: 2023-09-11 https://nodejs.org/en/blog/announcements/nodejs16-eol/ Node 18 EOL: 2025-04-30 Follow-up - facebook#34171 - facebook#32980 Ref - react-native-community/docker-android#187 cc ramonmedel cortinico gengjiawen ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [JavaScript] [Changed] - Bump node version from 16 to 18 Pull Request resolved: facebook#35443 Test Plan: Everything builds and runs as expected Reviewed By: cipolleschi Differential Revision: D41531161 Pulled By: cortinico fbshipit-source-id: 305888f55ed179f75bef34548aebf22fc2951308
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog:
[General][Added] - Added files for
avn,nodenv, and other managers that set the node.js version in reactive native project including testingReviewed By: cortinico
Differential Revision: D37683291