Skip to content

Enable Generic Discontiguous Regions within VirtualizedList #32638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NickGerleman wants to merge 3 commits into from
Closed

Enable Generic Discontiguous Regions within VirtualizedList #32638

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1cff8dc
Enable Generic Discontiguous Regions within VirtualizedList
NickGerleman Nov 21, 2021
b1dd0c3
office-shared-comments-ui ee041633
NickGerleman Dec 7, 2021
76859b5
office-shared-comments-ui aeb76bb4
NickGerleman Dec 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Libraries/Lists/CellRenderMask.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,10 @@ export class CellRenderMask {
);
}

numCells(): number {
return this._numCells;
}

equals(other: CellRenderMask): boolean {
return (
this._numCells === other._numCells &&
Expand Down
2 changes: 0 additions & 2 deletions Libraries/Lists/VirtualizeUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ export function computeWindowedRenderLimits(
prev: {
first: number,
last: number,
...
},
getFrameMetricsApprox: (index: number) => {
length: number,
Expand All @@ -109,7 +108,6 @@ export function computeWindowedRenderLimits(
): {
first: number,
last: number,
...
} {
const itemCount = getItemCount(data);
if (itemCount === 0) {
Expand Down
Loading