Skip to content

Prevent native blob resource from being de-allocated prematurely #31392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
awinograd wants to merge 2 commits into from
Closed

Prevent native blob resource from being de-allocated prematurely #31392

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f1420ce
Prevent native blob resource from being de-allocated prematurely
awinograd Apr 20, 2021
d064dfe
fix trailing spacing
awinograd Apr 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions Libraries/Blob/Blob.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,12 @@ class Blob {
blobId: this.data.blobId,
offset,
size,
/* Since `blob.slice()` creates a new view onto the same binary
* data as the original blob, we should re-use the same collector
* object so that the underlying resource gets deallocated when
* the last view into the data is released, not the first.
*/
__collector: this.data.__collector,
});
}

Expand Down