Disable accessibilityState when TouchableWithoutFeedback is disabled
#31297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
analysis-bot
suggested changes
Apr 4, 2021
analysis-bot
left a comment
analysis-bot
left a comment
There was a problem hiding this comment.
Code analysis results:
eslintfound some issues. Runyarn lint --fixto automatically fix problems.
Base commit: 73b9f78 |
carloscuesta
changed the title
accessibilityState when the TouchableWithoutFeedback is disabledaccessibilityState when TouchableWithoutFeedback is disabled
kacieb
suggested changes
Apr 13, 2021
Libraries/Components/Touchable/__tests__/__snapshots__/TouchableWithoutFeedback-test.js.snap
Outdated
Show resolved
Hide resolved
Libraries/Components/Touchable/__tests__/__snapshots__/TouchableWithoutFeedback-test.js.snap
Show resolved
Hide resolved
Contributor
Author
|
Fixed the case found on snapshots with your suggestion @kacieb 😊 |
Contributor
|
@kacieb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Contributor
carloscuesta
deleted the
disable-click-functionality-a11y-TouchableWithoutFeedback
branch
|
Thank you @carloscuesta for this contribution to a more accessible React Native! I would like to give you a shout-out on Twitter and include you in our end-of-month issues update for your contribution. Do you have a Twitter we can tag? |
Contributor
Author
|
Sure @amarlette! Here's my twitter handle @crloscuesta |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Disable
accessibilityStatewhen theTouchableWithoutFeedbackisdisabled. This fixes #30953Changelog
[General] [Changed] - Disable
accessibilityStatewhen theTouchableWithoutFeedbackisdisabled.Test Plan
Tested the
TouchableWithoutFeedbackcomponent on an Android device