Skip to content

Added sharedAction example to Share API #30333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kshitij86 wants to merge 3 commits into from
Closed

Added sharedAction example to Share API #30333

kshitij86 wants to merge 3 commits into from

Conversation

@kshitij86
Copy link
Contributor

@kshitij86 kshitij86 commented Nov 7, 2020

Summary

  • Added an example for sharedAction and dismissedAction in Share API examples

Motivation - Missing example for sharedAction in examples

Changelog

[General] [Added] - Added an example in ShareExample.js

Test Plan

  • Tested on Android

sharedAction

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 7, 2020

Hi @kshitij86!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@react-native-bot react-native-bot added the Type: Enhancement A new feature or enhancement of an existing feature. label Nov 7, 2020
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 7, 2020
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Nov 7, 2020

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@analysis-bot
Copy link

analysis-bot commented Nov 7, 2020 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 53862a1

@analysis-bot
Copy link

analysis-bot commented Nov 7, 2020

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,508,552 +741
android hermes armeabi-v7a 7,100,061 +738
android hermes x86 7,946,486 +748
android hermes x86_64 7,857,518 +741
android jsc arm64-v8a 8,972,427 +0
android jsc armeabi-v7a 8,547,052 +0
android jsc x86 8,971,859 +0
android jsc x86_64 9,523,158 +0

Base commit: 017bc91

@mkcode mkcode force-pushed the mlh-fellowship-examples-share branch from f4e129a to 5d0ba69 Compare November 13, 2020 17:21
@mkcode
Copy link
Contributor

mkcode commented Nov 13, 2020

This great to me.

@kshitij86
Copy link
Contributor Author

kshitij86 commented Nov 18, 2020

@rickhanlonii Could you please review these changes?

@rickhanlonii
Copy link
Member

rickhanlonii commented Dec 1, 2020

Looks like the android test failed, I re-ran the jobs and if it passes I'll import it.

facebook-github-bot
facebook-github-bot reviewed Dec 1, 2020
View reviewed changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rickhanlonii has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

rickhanlonii
rickhanlonii reviewed Dec 15, 2020
View reviewed changes
Libraries/Components/ScrollView/ScrollViewStickyHeader.js
// eslint-disable-next-line dot-notation
const isFabric = !!(
this._ref && this._ref['_internalInstanceHandle']?.stateNode?.canonical
this._ref && this._ref._internalInstanceHandle?.stateNode?.canonical
Copy link
Member

@rickhanlonii rickhanlonii Dec 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we revert this?

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 8, 2021

@rickhanlonii merged this pull request in 835117a.

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Jan 8, 2021
@rickhanlonii rickhanlonii deleted the mlh-fellowship-examples-share branch January 8, 2021 21:15
facebook-github-bot pushed a commit that referenced this pull request Jan 12, 2021
@sammy-SC @facebook-github-bot
Fix detection of Fabric in ScrollViewStickyHeader
c42a59a 
Summary:
Changelog: [internal]

Revert a change introduced in #30333 where rickhanlonii asked it to be reverted as well.

The change breaks sticky header in Fabric.

Reviewed By: rubennorte

Differential Revision: D25883861

fbshipit-source-id: b01305c6def390d0664c7be939ab3fc72186a07a
amgleitman pushed a commit to amgleitman/react-native-macos that referenced this pull request Aug 24, 2021
@sammy-SC @amgleitman
Fix detection of Fabric in ScrollViewStickyHeader
dd4f7e6 
Summary:
Changelog: [internal]

Revert a change introduced in facebook#30333 where rickhanlonii asked it to be reverted as well.

The change breaks sticky header in Fabric.

Reviewed By: rubennorte

Differential Revision: D25883861

fbshipit-source-id: b01305c6def390d0664c7be939ab3fc72186a07a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickhanlonii rickhanlonii rickhanlonii left review comments

@facebook-github-bot facebook-github-bot facebook-github-bot left review comments

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Type: Enhancement A new feature or enhancement of an existing feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kshitij86 @facebook-github-bot @analysis-bot @mkcode @rickhanlonii @react-native-bot