Skip to content

Conversation

@ejanzer
Copy link

@ejanzer ejanzer commented Jun 8, 2020

Summary: Moving the logic for calling into JS to handle errors into ErrorUtils, where it can be reused outside of the bridge.

Differential Revision: D21939254

Summary: Moving the logic for calling into JS to handle errors into ErrorUtils, where it can be reused outside of the bridge.

Differential Revision: D21939254

fbshipit-source-id: 78271ba7a4e7627021d0e845a39f68a5dca19724
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner RN Team fb-exported labels Jun 8, 2020
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D21939254

@pull-bot
Copy link

pull-bot commented Jun 8, 2020

Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

DetailsCATEGORY may be:
  • General
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.

📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 81db241

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 6,760,810 17
android hermes armeabi-v7a 6,423,764 -20
android hermes x86 7,147,235 -7
android hermes x86_64 7,037,217 -10
android jsc arm64-v8a 8,934,370 -10
android jsc armeabi-v7a 8,589,735 -20
android jsc x86 8,763,937 4
android jsc x86_64 9,339,546 -11

Base commit: a5386ff

@analysis-bot
Copy link

analysis-bot commented Jun 8, 2020

Platform Engine Arch Size (bytes) Diff
ios - universal 829,440 -9,955,920

Base commit: a5386ff

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @ejanzer in 9263085.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner RN Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants