iOS: Make RCTKeyWindow multi-window aware and add UIScene support to RCTRedBox #28147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
RNTester (Android/hermes/arm64-v8a): 3291136 bytes |
|
RNTester.app (iOS): 10657792 bytes |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@hramos has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
This pull request was successfully merged by @tido64 in d0a32c2. When will my fix make it into a release? | Upcoming Releases |
tom-un
added a commit
to tom-un/react-native
that referenced
this pull request
Mar 6, 2020
Cherry pick facebook#28147 into fork to Make RCTKeyWindow multi-window aware and add UIScene support to RCTRedBox.
4 tasks
tom-un
added a commit
to microsoft/react-native-macos
that referenced
this pull request
Mar 7, 2020
…IScene support from upstream. (#256) * Fix manual merge error. * Fix missing getters from react-native-implementation.macos.js. Cherry pick facebook#28147 into fork to Make RCTKeyWindow multi-window aware and add UIScene support to RCTRedBox. * release _window now to ensure its UIKit ivars are dealloc'd on the main thread as the RCTRedBox can be dealloc'd on a background thread
osdnk
pushed a commit
to osdnk/react-native
that referenced
this pull request
Mar 9, 2020
…RCTRedBox (facebook#28147) Summary: `RCTRedBox` doesn't appear in apps implementing `UISceneDelegate`. ## Changelog [iOS] [Changed] - `RCTKeyWindow()` is now multi-window aware [iOS] [Fixed] - `RCTRedBox` doesn't appear in apps implementing `UISceneDelegate` Pull Request resolved: facebook#28147 Test Plan: - Trigger an error in RNTester - Trigger an error in an app implementing `UISceneDelegate`  Reviewed By: PeteTheHeat Differential Revision: D20036399 Pulled By: hramos fbshipit-source-id: 07d83e985b02296f930114e3c7100c2077e82300
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RCTRedBoxdoesn't appear in apps implementingUISceneDelegate.Changelog
[iOS] [Changed] -
RCTKeyWindow()is now multi-window aware[iOS] [Fixed] -
RCTRedBoxdoesn't appear in apps implementingUISceneDelegateTest Plan
UISceneDelegate