[FIX] ListView requestAnimationFrame leak #21802
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
Author
|
@RSNara Yep for sure, I find it clearer ! |
RSNara
approved these changes
Oct 15, 2018
Contributor
RSNara
left a comment
RSNara
left a comment
There was a problem hiding this comment.
Thanks for the quick changes! 😁
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Oct 15, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
RSNara is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
kelset
pushed a commit
that referenced
this pull request
Oct 23, 2018
Summary: Related to #21488 Disclaimer: I made this PR. I think there's some requestAnimationFrame events that are not cleared on unmount because of bad use of `splice` method. - All flow tests succeed. - RNTester: iOS (this change should only affect iOS because calculateChildFrames is iOS only) Show perf monitor, show ListView* screen, start scrolling. UI frame Rate is used at the beginning. When scrolling there is no drop in FPS rate. - TODO: I'll write a load test for ListView [GENERAL] [ENHANCEMENT] [ListView.js] - rm TimerMixin Pull Request resolved: #21802 Differential Revision: D10391812 Pulled By: RSNara fbshipit-source-id: 49f0b0a4641ec29bcb4cc04bd3bafb42b3842b69
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: Related to facebook#21488 Disclaimer: I made this PR. I think there's some requestAnimationFrame events that are not cleared on unmount because of bad use of `splice` method. - All flow tests succeed. - RNTester: iOS (this change should only affect iOS because calculateChildFrames is iOS only) Show perf monitor, show ListView* screen, start scrolling. UI frame Rate is used at the beginning. When scrolling there is no drop in FPS rate. - TODO: I'll write a load test for ListView [GENERAL] [ENHANCEMENT] [ListView.js] - rm TimerMixin Pull Request resolved: facebook#21802 Differential Revision: D10391812 Pulled By: RSNara fbshipit-source-id: 49f0b0a4641ec29bcb4cc04bd3bafb42b3842b69
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #21488
Disclaimer: I made this PR.
I think there's some requestAnimationFrame events that are not cleared on unmount because of bad use of
splicemethod.Test Plan:
Show perf monitor, show ListView* screen, start scrolling. UI frame Rate is used at the beginning. When scrolling there is no drop in FPS rate.
Release Notes:
[GENERAL] [ENHANCEMENT] [ListView.js] - rm TimerMixin