Skip to content

Conversation

@filipengberg
Copy link

Fixes #21539

Ran npm test-ios-e2e and all tests are passing after upgrade.

@filipengberg filipengberg requested a review from hramos as a code owner October 8, 2018 15:14
@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@filipengberg filipengberg changed the title Upgrade Detox to 9.x Bump Detox to 9.x Oct 8, 2018
@pull-bot
Copy link

pull-bot commented Oct 8, 2018

Warnings
⚠️

🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

⚠️

📋 Test Plan - This PR appears to be missing a Test Plan.

⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

Generated by 🚫 dangerJS

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 8, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@kelset
Copy link
Contributor

kelset commented Oct 9, 2018

Closing since we are already importing #21570 (we submitted the PRs basically at the same time 😅 - thanks anyway!)

@kelset kelset closed this Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants