Expose a getter for overflow setting in ReactViewGroup #21398
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Contributor
|
Are you planning on fixing overflow hit testing for regular touch handling as well? |
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 28, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
|
@kmagiera merged commit 02ad56f into Once this commit is added to a release, you will see the corresponding version tag below the description at 02ad56f. If the commit has a single |
grabbou
pushed a commit
that referenced
this pull request
Oct 2, 2018
Summary: This change adds getter for overflow attribute in ReactViewGroup class. Overflow setting can affect how view children are drawn but also how hit testing behaves when receiving touch. Exposing this setting makes it possible for gesture-handler library to implement proper hit testing that takes into account overflow property of a view. Pull Request resolved: #21398 Differential Revision: D10105398 Pulled By: shergin fbshipit-source-id: 15ae2b31be3bf80e7e1d28b87ce4474af0f486f5
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: This change adds getter for overflow attribute in ReactViewGroup class. Overflow setting can affect how view children are drawn but also how hit testing behaves when receiving touch. Exposing this setting makes it possible for gesture-handler library to implement proper hit testing that takes into account overflow property of a view. Pull Request resolved: facebook#21398 Differential Revision: D10105398 Pulled By: shergin fbshipit-source-id: 15ae2b31be3bf80e7e1d28b87ce4474af0f486f5
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds getter for overflow attribute in ReactViewGroup class. Overflow setting can affect how view children are drawn but also how hit testing behaves when receiving touch. Exposing this setting makes it possible for gesture-handler library to implement proper hit testing that takes into account overflow property of a view.
Test Plan:
This change only adds a getter function that will be used by external libraries.
Release Notes:
[ANDROID] [MINOR] [ReactViewGroup] - Expose a getter for overflow setting in ReactViewGroup