[CI] Use ShellCheck #19681
Closed
[CI] Use ShellCheck #19681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
react-native-bot
added
Missing Test Plan
hramos
force-pushed
the
run-shellcheck
branch
2 times, most recently
from
0856b9e to
2ae6b4e
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
hramos
force-pushed
the
run-shellcheck
branch
4 times, most recently
from
cd2f3d4 to
87efe80
Compare
Generated by 🚫 dangerJS |
hramos
force-pushed
the
run-shellcheck
branch
4 times, most recently
from
2bf7a4e to
f193de5
Compare
analysis-bot
suggested changes
Sep 27, 2018
analysis-bot
left a comment
analysis-bot
left a comment
There was a problem hiding this comment.
eslint found some issues. You may run yarn prettier or npm run prettier to fix these.
| const body = | ||
| '`eslint` found some issues. You may run `yarn prettier` or `npm run prettier` to fix these.'; | ||
| const event = 'REQUEST_CHANGES'; | ||
|
|
There was a problem hiding this comment.
no-unused-vars: 'sendComment' is defined but never used.
hramos
force-pushed
the
run-shellcheck
branch
3 times, most recently
from
c04a9cb to
4589727
Compare
hramos
commented
Sep 28, 2018
Contributor
Author
hramos
left a comment
hramos
left a comment
There was a problem hiding this comment.
Code analysis results:
shellcheckfound some issues.
hramos
force-pushed
the
run-shellcheck
branch
3 times, most recently
from
9e64c65 to
d7246b7
Compare
hramos
force-pushed
the
run-shellcheck
branch
from
d7246b7 to
7d5ddad
Compare
facebook-github-bot
added
the
Import Started
facebook-github-bot
approved these changes
Sep 28, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Collaborator
hramos
removed
Import Started
t-nanava
pushed a commit
to microsoft/react-native-macos
that referenced
this pull request
Jun 17, 2019
Summary: As recommended in https://circleci.com/docs/2.0/using-shell-scripts/#use-shellcheck It will only run on PRs for now. Pull Request resolved: facebook#19681 Differential Revision: D10111711 Pulled By: hramos fbshipit-source-id: e980a526561dced79e5197a11cfb41a3eba9be8b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended in https://circleci.com/docs/2.0/using-shell-scripts/#use-shellcheck
It will only run on PRs for now.